Skip to content

build: CI rework #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Alystrasz wants to merge 23 commits into
base: main
Choose a base branch
from
Open

build: CI rework #66

Alystrasz wants to merge 23 commits into from

Conversation

@Alystrasz
Copy link
Member

@Alystrasz Alystrasz commented Dec 28, 2025

(this is not a mod verification request)

Updates the CI running on mod verification in the following aspects:

  • Fetches mod archives and compares their checksum with the one registered in verified-mods.json;
    • (reviewers then only need to read the content of the archive)
  • Ensures mod name from verified-mods.json and mod name from archive are identical;
  • Splits logic in packages, and unit tests them.
image

Closes #15 #48 #61

@Alystrasz
refactor: reorganize CI to do several things per mod version
df181b4
@Alystrasz
feat: add archive checks package with basic methods
1724d37
@Alystrasz
test: add unit tests for fetch_archive method
a4e5a89
@Alystrasz
refactor: rewrite version string template
6783263
@Alystrasz
feat: integrate checksum to main action
c5bf19d
@Alystrasz
fix: review error message template
c54c5a7
@Alystrasz
feat: remove faulty parkour entry
6247517
@Alystrasz
fix?
f0c7c54
@Alystrasz
build: make CI install Python dependencies
2eadb22
@Alystrasz
feat: integrate mod name checking to main action
66d4072
@Alystrasz
fix: print error messages before returning
4e8aaf6
@Alystrasz
fix: skip name verification if package contains several mods
beadf94
@Alystrasz
test: add unit tests for check_archive method
7313145
@Alystrasz
docs: add documentation to archive methods
f9fc08e
@Alystrasz
test: add missing test hash argument
77b4c2d
@Alystrasz
test: add unit tests for check_mod_name method
15066b0
@Alystrasz
fix: check_mod_name returns false if input archive does not exist
9832b36
@Alystrasz
refactor: export github logic to dedicated package
3e232ec
@Alystrasz
refactor: defer API link build to github package
e81b745
@Alystrasz
test: add unit tests for build_tags_url method
97e63ec
@Alystrasz
fix: build_tags_url returns false with malformatted input
d72faad
@Alystrasz
docs: rewrite verify_all_mod_versions documentation
1a4eb56
This was linked to issues Dec 28, 2025
Verify JSON mod entry name matches mod.json mod name #48
Open
Relax dependency to Thunderstore #61
Open
@Alystrasz
Copy link
Member Author

Alystrasz commented Dec 28, 2025

You can see the effects of this PR by checking the action log ("Run mod checks" job) here: https://github.com/R2Northstar/VerifiedMods/actions/runs/20560876495/job/59051322157?pr=66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Relax dependency to Thunderstore Verify JSON mod entry name matches mod.json mod name Improve automations for faster workflow

1 participant

@Alystrasz