Conversation
… for request which is not needed for garmin oauth
Re-added the Garmin OAuth 1 authorization service
Fix missing user_id during token refresh
Add project ID to account already registered error message
Garmin OAuth migration from OAuth 1.0 to OAuth 2.0
…/20260204120000_add_code_verifier_column.xml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@copilot apply changes based on the comments in this thread |
…fault Agent-Logs-Url: https://github.com/RADAR-base/RADAR-Rest-Source-Auth/sessions/5b3b0732-8fa7-40be-8165-632e8488c4f8 Co-authored-by: this-Aditya <98681758+this-Aditya@users.noreply.github.com>
Applied all changes from the review thread in commit
Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Use speicific logger per oauth service
| } | ||
|
|
||
| override suspend fun deregisterUser(user: RestSourceUser) { | ||
| userRepository.delete(user) |
There was a problem hiding this comment.
do we need to deregister on Garmin too (call the deleteRegistration function) ?
There was a problem hiding this comment.
I think we don't need to do this as it is called by reportDeregistration which is triggered by garmin push service when the user has already revoked permissions on Garmin's side.
We just need to clean up our own DB, not send the deregistration again.
yatharthranjan
left a comment
There was a problem hiding this comment.
Thanks guys, nice work!. It looks already quite good, just some comments to improve robustness.
Uh oh!
There was an error while loading. Please reload this page.