Skip to content

Release 4.4.15#324

Open
mpgxvii wants to merge 45 commits intomasterfrom
release-4.4.15
Open

Release 4.4.15#324
mpgxvii wants to merge 45 commits intomasterfrom
release-4.4.15

Conversation

@mpgxvii
Copy link
Copy Markdown
Member

@mpgxvii mpgxvii commented Mar 26, 2026

this-Aditya and others added 30 commits February 4, 2026 12:44
… for request which is not needed for garmin oauth
Re-added the Garmin OAuth 1 authorization service
Fix missing user_id during token refresh
Add project ID to account already registered error message
Garmin OAuth migration from OAuth 1.0 to OAuth 2.0
…/20260204120000_add_code_verifier_column.xml

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@this-Aditya
Copy link
Copy Markdown
Member

@copilot apply changes based on the comments in this thread

Copy link
Copy Markdown

Copilot AI commented Mar 27, 2026

@copilot apply changes based on the comments in this thread

Applied all changes from the review thread in commit 0bc09fc:

  • oauthVersion default changed from "oauth2" to "oauth1" in RestSourceClient.kt to avoid breaking existing Garmin OAuth1 configs
  • Removed sensitive one-time token values from both exception messages in GarminOAuth2AuthorizationService.kt (both now use "code verifier not found for provided state token")
  • Used checkNotNull for client_id and client_secret in refreshToken (consistent with the existing pattern in requestAccessToken)

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • o1.ingest.sentry.io
    • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED -XX:MaxMetaspaceSize=384m -XX:&#43;HeapDumpOnOutOfMemoryError -Xms256m -Xmx512m -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

this-Aditya
this-Aditya previously approved these changes Mar 27, 2026
}

override suspend fun deregisterUser(user: RestSourceUser) {
userRepository.delete(user)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to deregister on Garmin too (call the deleteRegistration function) ?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't need to do this as it is called by reportDeregistration which is triggered by garmin push service when the user has already revoked permissions on Garmin's side.
We just need to clean up our own DB, not send the deregistration again.

Comment thread authorizer-app-backend/authorizer.yml Outdated
Copy link
Copy Markdown
Member

@yatharthranjan yatharthranjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks guys, nice work!. It looks already quite good, just some comments to improve robustness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants