Release 0.8.16 by pvannierop · Pull Request #416 · RADAR-base/RADAR-Schemas

pvannierop · 2026-03-10T18:14:29Z

This PR will:

Impl. Gradle version catalog
Upgrade Gradle to v8.14
Apply March 2026 security updates
Add support for Sentry monitoring and Open Telemetry

Improve version management and use of convention plugins for shared build logic.

Add support for Sentry monitoring

this-Aditya · 2026-03-12T18:51:49Z

+plugins {
+    id("org.radarbase.radar-kotlin")
+}
+
+val libs = extensions.getByType<VersionCatalogsExtension>().named("libs")
+
+// Versions of many dependencies defined by radar-commons-kotlin.
+radarKotlin {
+    log4j2Version.set(libs.findVersion("log4j2").get().toString())
+    sentryEnabled.set(true)
+    openTelemetryAgentEnabled.set(false)
+}


Nice work on this modernization. I think using convention plugins might be a bit over engineered for our case, since we're wrapping one plugin in another plugin (same with publishing-convention.gradle.kts). Would a subprojects {} block in the root build file achieve the same thing (like how it currently works with the combination of subprojects and configure blocks) with less complexity? Not opposed to it, just wondering if you considered that route and chose convention plugins intentionally.

@this-Aditya point for discussion. I learned from the gradle docs that using subprojects is at the moment considered an anti-pattern (see here). I figured we may just as well do it the 'right way' when needed. We can chose to go back to subprojects section I guess because we do not have a lot of logic there and it is more easy to understand to users not so well versed in Gradle.

I realize I chose to use subprojects {...} to declare the pinned dependencies for visibility reasons also.

this-Aditya · 2026-03-12T19:16:21Z


 plugins {
-    id("com.github.davidmc24.gradle.plugin.avro-base")
+    id("java-library")


I think it is already applied in root build

this-Aditya · 2026-03-12T19:17:04Z

@@ -1,40 +1,42 @@
 plugins {
-    kotlin("plugin.allopen")
+    id("java-library")


Same here, this is already applied in root buildscript

this-Aditya · 2026-03-12T19:17:36Z

@@ -1,17 +1,22 @@
+plugins {
+    id("java-library")


This plugin is already applied in root build

this-Aditya · 2026-03-12T19:21:51Z

-    afterEvaluate {
-        configurations.all {
-            exclude(group = "org.slf4j", module = "slf4j-log4j12")
-        }
-    }


Are you sure this isn’t being pulled in transitively by any dependency now? I don’t see it excluded anywhere.

That is strange. I use the 'Vulerable dependencies' tab/tool in IntelliJ IDEA and this no longer shows the vulnerable dependencies:

H maven:com.fasterxml.jackson.core:jackson-core:2.20.2
M maven:com.squareup.okio:okio-jvm:3.2.0
H maven:com.fasterxml.woodstox:woodstox-core:6.2.4
M maven:io.ktor:ktor-client-core-jvm:2.3.4
H maven:com.fasterxml.jackson.core:jackson-core:2.12.7
M maven:io.ktor:ktor-network-tls-jvm:2.3.4
M maven:org.apache.logging.log4j:log4j-core:2.20.0
M maven:io.ktor:ktor-client-core-jvm:2.3.9
L maven:org.glassfish.grizzly:grizzly-http:4.0.2

Co-authored-by: Aditya Mishra <98681758+this-Aditya@users.noreply.github.com>

this-Aditya · 2026-03-16T21:28:54Z

    radarKotlin {
-        javaVersion.set(Versions.java)
+        log4j2Version.set(rootProject.libs.versions.log4j2)
    }


it's already set in the subprojects {} above, so they inherit that configuration, we can remove this.

Ok, the difference here is the packaging of the Sentry Jar. Intended the Sentry JAR to be packaged by applications only, not the library projects. Would the current construct achieve this?

Yeah it does achieve this, but what are your thoughts on keeping the default sentryEnabled to false in the subprojects block? That way, at the outer scope we have false by default for any new subproject we add.

Yes, that sounds great. I have updated the respective sections. I am unsure whether I need to repeat setting the log4j version. I think not, but I do not know how to test this.

this-Aditya · 2026-03-16T21:33:50Z

    apply(plugin = "java-library")
-    apply(plugin = "org.radarbase.radar-kotlin")
    apply(plugin = "org.radarbase.radar-publishing")
+    apply(plugin = "org.radarbase.radar-kotlin")


radar-kotlin is already set in the subprojects block above, so it applied here too without specifying here.

Lets discuss the right approach for adding the Sentry JAR.

Thanks for the context on Sentry. Right now sentryEnabled.set(true) is set in the subprojects {} block, which means it applies to all 5 modules including the libraries. If the intent is for only applications to have Sentry, maybe we should move sentryEnabled.set(true) and openTelemetryAgentEnabled.set(true) to the application configure block instead? That way the default at the outer scope (subprojects block) stays false, and only the apps get Sentry.

Also, I think we can configure the radarKotlin block in the configure block without re-applying the plugin, it's already applied in subprojects {}

Update committed.

PR feedback Aditya

…radar-jersey

this-Aditya

Thanks for the changes, LGTM 🎉

Update radar-commons

5515213

pvannierop requested a review from this-Aditya March 10, 2026 18:14

pvannierop self-assigned this Mar 10, 2026

pvannierop force-pushed the release-0.8.16 branch from 7ce2783 to fa6de53 Compare March 11, 2026 06:21

pvannierop added 7 commits March 11, 2026 07:26

Impl. version catalog

5ef43dd

Clean up gradle code

0e893cf

Remove buildSrc directory

60f0241

Fix deprecation warnings

901ada4

Upgrade to gradle 8.14

5f44769

Apply March 2026 security updates

dd91607

Set project version to 0.8.16

d8a4cc1

pvannierop force-pushed the release-0.8.16 branch from 9392fbb to d8a4cc1 Compare March 11, 2026 06:28

pvannierop added 5 commits March 12, 2026 08:21

Refactor gradle configuration

ab68fe7

Improve version management and use of convention plugins for shared build logic.

Add Sentry support

e29ac83

March 2026 security update

8edca59

Merge pull request #387 from RADAR-base/feature/sentry

c45d958

Add support for Sentry monitoring

Fix build with convention plugins

a34cbd5

pvannierop force-pushed the release-0.8.16 branch from aef2cb6 to a34cbd5 Compare March 12, 2026 09:04

Do not package Open Telemetry package

95e501f

this-Aditya reviewed Mar 12, 2026

View reviewed changes

Update java-sdk/build.gradle.kts

2e0a640

Co-authored-by: Aditya Mishra <98681758+this-Aditya@users.noreply.github.com>

this-Aditya reviewed Mar 16, 2026

View reviewed changes

Revert back to Gradle subprojects construct

e1a2a11

PR feedback Aditya

pvannierop force-pushed the release-0.8.16 branch from 17840d2 to e1a2a11 Compare March 17, 2026 07:27

Streamline radarKotlin plugin config across projects

662987d

PR feedback Aditya

pvannierop force-pushed the release-0.8.16 branch from f0085c8 to 662987d Compare March 17, 2026 11:52

pvannierop added 2 commits March 17, 2026 13:16

Fix snapshot release action

7e49a46

Clarify circular dependency between radar-commons, radar-schemas and …

fe1368c

…radar-jersey

this-Aditya approved these changes Mar 18, 2026

View reviewed changes

this-Aditya merged commit 968f4f1 into master Mar 18, 2026
2 of 6 checks passed

this-Aditya deleted the release-0.8.16 branch March 18, 2026 10:39

pvannierop restored the release-0.8.16 branch March 18, 2026 14:55

Conversation

pvannierop commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pvannierop Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pvannierop Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

this-Aditya left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

pvannierop commented Mar 10, 2026 •

edited

Loading

pvannierop Mar 13, 2026 •

edited

Loading

pvannierop Mar 17, 2026 •

edited

Loading