fix: Include SPM resource bundles in .app (fixes launch crash)#20
Merged
fix: Include SPM resource bundles in .app (fixes launch crash)#20
Conversation
KeyboardShortcuts uses Bundle.module to load resources. The release workflow only copied the executable, causing fatalError on launch. Fix: Copy all *.bundle from .build/*/release/ into .app/Contents/Resources/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v1.2.0 crashes on launch with
EXC_BREAKPOINTinBundle.module.Cause:
KeyboardShortcutsusesBundle.modulefor resources, but the release workflow only copied the executable into the .app bundle.Fix: Copy all
.bundledirectories from the release build into.app/Contents/Resources/.