Skip to content

Conversation

@thuanhuynhh
Copy link

Update for OJS 3.5.0

@RBoelter
Copy link
Owner

RBoelter commented Jan 5, 2026

Hi @thuanhuynhh

Thank you for your contribution and for working on updates for OJS 3.5.0. I noticed that this pull request has over 1800 loc marked as changed, which makes reviewing the real changes very challenging.

It seems like the large number of changes might be due to unintended modifications, such as:

  • Line endings (e.g., Windows vs. Unix style).
  • File encoding or permissions being altered.

To ensure the review process goes smoothly, could you please verify and isolate the actual intended changes? Here are some possible steps:

  1. Check for unintended modifications using git diff.
  2. Reconfirm your Git configuration for line-endings by running:
    git config --global core.autocrlf true  
  3. If necessary, create a new branch with only the intended changes and update the PR.

This will help us focus only on the key changes needed for the update and greatly ease the review process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants