Simplify asset management by rohitkulkarni97 · Pull Request #1487 · RE-SS3D/SS3D

rohitkulkarni97 · 2026-02-04T17:52:45Z

Summary

Simplifies asset management and makes it robust by using GUIDs instead of names for referencing. Step 1 to introduce the Addressables system.

PR checklist

The game builds properly without errors.

No unrelated changes are present.

No "trash" files are committed.

Relevant code is documented.

Update the related GitBook document, or create a new one if needed.

Pictures/Videos

Testing

Networking checklist

Works from host in host mode.

Works from server in server mode.

Works on server in client mode.

Works and is syncronized across different clients.

Is persistent.

Changes

DatabaseAsset is removed instead, const strings are used in different asset database scripts, which now contain the GUID of the prefab instead of the name.
WorldObjectAssetReference is now named as ObjectAssetReference, because it serves more than the one purpose it was designed for.
RoleData and RoleLoadout use ObjectAssetReference instead of direct prefabs.
ObjectAssetReference now stores the GUID of the preab and the GUID of the database instead of their names.
GenericObjectSo uses ObjectAssetReference instead of prefabs directly.
Scripts using a list of audio clips to play via the audio subsystem use ObjectAssetReference instead, as the audio subsystem loads the clip from Assets.Get() anyway.

Related issues/PRs

Closes #1259
Simplify the asset management workflow

…eters in asset creation methods, and removing DatabaseAsset.cs usage.

….Get method instead of DatabaseAsset's Prefab property, Create, Get<T>() & CreateAs<T>(...) functions, and different implicit operators.

…Creator and DatabaseScriptWriter for consistency in asset management workflow.

…, and Item to use Assets.Get method for improved consistency and clarity

…to use Assets.Get method for improved consistency

…and other places to streamline asset retrieval

…agement consistency

…tepCraftable, and Item to simplify usage of Assets.Get method

…nce to streamline addressable asset handling and improve code clarity

…nstructionHologramManager to utilize WorldObjectAssetReference for improved asset retrieval

…bjectsSO prefabs to enhance asset management

…eferences throughout the codebase for consistency

…proved readability

…AssetReference, and implement IEqualityComparer for improved comparison

…lementation and simplifying equality and hash code methods

…eters in asset creation methods, and removing DatabaseAsset.cs usage.

….Get method instead of DatabaseAsset's Prefab property, Create, Get<T>() & CreateAs<T>(...) functions, and different implicit operators.

…Creator and DatabaseScriptWriter for consistency in asset management workflow.

…, and Item to use Assets.Get method for improved consistency and clarity

…to use Assets.Get method for improved consistency

…and other places to streamline asset retrieval

…agement consistency

… consistency

…ionality and improve code organization

…bility

iamteapot422

Multiple errors in editor

iamteapot422 · 2026-02-22T17:26:48Z

Assets/Scripts/SS3D/Data/AssetDatabases/AssetDatabasesCodeGenerator.cs


-                    string key = $"{WorldObjectAssetPath}{worldObjectAssetReference.Id}.asset";
+                    string key = $"{ObjectAssetReference.ObjectAssetPath}{gameObject.name}.asset";


"Cannot resolve symbol 'ObjectAssetPath'"

Don't have that error at my end, maybe it might be due to the missing ; (again I'm extremely sorry, I'm stupid)

Assets/Scripts/SS3D/Data/AssetDatabases/ObjectAssetReference.Editor.cs

iamteapot422 · 2026-02-22T19:47:31Z

Why was ObjectAssetReference.Create() removed?

rohitkulkarni97 · 2026-02-22T20:07:15Z

Multiple errors in editor

I'm sorry, my bad 🙏

rohitkulkarni97 · 2026-02-22T20:16:05Z

Why was ObjectAssetReference.Create() removed?

It was moved to ObjectAssetReference.Editor file as it is only valid in the editor. The Editor functions of the ObjectAssetReference class were moved from ObjectAssetReference.cs to ObjectAssetReference.Editor.cs.

iamteapot422

Error on building the project

Everything else (haven't checked networking yet) seems fine

…well.

rohitkulkarni97 · 2026-02-23T22:36:49Z

Error on building the project
Everything else (haven't checked networking yet) seems fine

Fixed

rohitkulkarni97 · 2026-02-23T22:38:26Z

Still getting errors

Editor:
Game:

Doesn't seem to happen at my end. Also, the scripts don't seem familiar to me. I haven't made changes to these files.

iamteapot422 · 2026-02-24T19:16:52Z

Still getting errors
Editor:

Game:

Doesn't seem to happen at my end. Also, the scripts don't seem familiar to me. I haven't made changes to these files.

Yeah, ten seconds after posting the review i have discarded the seemingly inoccuous changes and it worked

iamteapot422

Good work

rohitkulkarni97 added 30 commits January 27, 2026 16:14

Simplify asset management workflow by removing unnecessary type param…

2bca17b

…eters in asset creation methods, and removing DatabaseAsset.cs usage.

Refactor asset retrieval in interactions and components to use Assets…

0790a2c

….Get method instead of DatabaseAsset's Prefab property, Create, Get<T>() & CreateAs<T>(...) functions, and different implicit operators.

Removed the now unused class DatabaseAsset.cs

8d877fc

Rename DatabaseAssetCreator and DatabaseAssetWriter to DatabaseScript…

12db359

…Creator and DatabaseScriptWriter for consistency in asset management workflow.

Fixing error of using interaction icon for audio clip (stupid me)

39c8543

Commit 12db359 missing reference changes.

7cfa599

Refactor asset retrieval in WorldObjectAssetReference, CraftingRecipe…

9271a30

…, and Item to use Assets.Get method for improved consistency and clarity

Refactor asset retrieval in CraftingSubSystem and MultiStepCraftable …

13fbaa1

…to use Assets.Get method for improved consistency

Refactor asset management to use GUIDs for WorldObjectAssetReference …

2c2d75d

…and other places to streamline asset retrieval

Update asset IDs and databases for various items to improve asset man…

3cc5aa5

…agement consistency

Add new asset files and update prefab references for audio management

7c952e5

Refactor asset retrieval in CraftingRecipe, CraftingSubSystem, MultiS…

75223f2

…tepCraftable, and Item to simplify usage of Assets.Get method

Refactor asset management in AssetDatabase and WorldObjectAssetRefere…

49a8e4e

…nce to streamline addressable asset handling and improve code clarity

Refactor asset handling in PlacedItemObject, PlacedTileObject, and Co…

df284ba

…nstructionHologramManager to utilize WorldObjectAssetReference for improved asset retrieval

Add new world object asset references files for various objects TileO…

0c93416

…bjectsSO prefabs to enhance asset management

Rename WorldObjectAssetReference to ObjectAssetReference and update r…

8fb8751

…eferences throughout the codebase for consistency

Remove unused variable

2e6fd3f

Fix formatting and clean up conditions in DatabaseScriptWriter for im…

d83d0c4

…proved readability

Enhance asset retrieval by updating GetAsset methods to accept Object…

6e2810e

…AssetReference, and implement IEqualityComparer for improved comparison

Refactor ObjectAssetReference class by removing IEqualityComparer imp…

c64157e

…lementation and simplifying equality and hash code methods

Simplify asset management workflow by removing unnecessary type param…

d987816

…eters in asset creation methods, and removing DatabaseAsset.cs usage.

Refactor asset retrieval in interactions and components to use Assets…

dc30b74

….Get method instead of DatabaseAsset's Prefab property, Create, Get<T>() & CreateAs<T>(...) functions, and different implicit operators.

Removed the now unused class DatabaseAsset.cs

226c07c

Rename DatabaseAssetCreator and DatabaseAssetWriter to DatabaseScript…

2392b06

…Creator and DatabaseScriptWriter for consistency in asset management workflow.

Fixing error of using interaction icon for audio clip (stupid me)

32fb6ce

Commit 12db359 missing reference changes.

1be7b04

Refactor asset retrieval in WorldObjectAssetReference, CraftingRecipe…

5245559

…, and Item to use Assets.Get method for improved consistency and clarity

Refactor asset retrieval in CraftingSubSystem and MultiStepCraftable …

745481c

…to use Assets.Get method for improved consistency

Refactor asset management to use GUIDs for WorldObjectAssetReference …

3d0ea6d

…and other places to streamline asset retrieval

Update asset IDs and databases for various items to improve asset man…

be9e035

…agement consistency

rohitkulkarni97 temporarily deployed to unity_tests February 21, 2026 22:41 — with GitHub Actions Inactive

Improve logging in AssetDatabasesCodeGenerator for better clarity and…

d356bbe

… consistency

rohitkulkarni97 temporarily deployed to unity_tests February 21, 2026 23:00 — with GitHub Actions Inactive

Refactor ObjectAssetReference class to separate editor-specific funct…

064552b

…ionality and improve code organization

rohitkulkarni97 temporarily deployed to unity_tests February 21, 2026 23:22 — with GitHub Actions Inactive

Format Equals method in ObjectAssetReference class for improved reada…

8b88fce

…bility

rohitkulkarni97 temporarily deployed to unity_tests February 21, 2026 23:24 — with GitHub Actions Inactive

rohitkulkarni97 requested a review from iamteapot422 February 22, 2026 01:26

iamteapot422 requested changes Feb 22, 2026

View reviewed changes

rohitkulkarni97 added 3 commits February 22, 2026 14:57

-_-, I'm sorry

406d54b

Changed Debug.LogError to Log.Error

761bd22

Changed ObjectAssetReferences path

4e6e09a

rohitkulkarni97 temporarily deployed to unity_tests February 22, 2026 20:16 — with GitHub Actions Inactive

rohitkulkarni97 requested a review from iamteapot422 February 22, 2026 20:19

This comment was marked as resolved.

Sign in to view

iamteapot422 requested changes Feb 23, 2026

View reviewed changes

Moved #if UNITY_EDITOR to the top to include the using statements as …

b15db47

…well.

rohitkulkarni97 deployed to unity_tests February 23, 2026 22:36 — with GitHub Actions Active

rohitkulkarni97 requested a review from iamteapot422 February 24, 2026 16:07

iamteapot422 approved these changes Feb 24, 2026

View reviewed changes

iamteapot422 merged commit 3f7cf28 into RE-SS3D:develop Feb 24, 2026
2 checks passed

iamteapot422 changed the title ~~Simplify the asset management workflow #1259~~ Simplify the asset management Feb 24, 2026

iamteapot422 changed the title ~~Simplify the asset management~~ Simplify asset management Feb 24, 2026

rohitkulkarni97 deleted the Issues/Simplify-the-asset-management-workflow-#1259 branch February 24, 2026 21:32


		string key = $"{WorldObjectAssetPath}{worldObjectAssetReference.Id}.asset";
		string key = $"{ObjectAssetReference.ObjectAssetPath}{gameObject.name}.asset";

Uh oh!

Conversation

rohitkulkarni97 commented Feb 4, 2026

Summary

PR checklist

Pictures/Videos

Testing

Networking checklist

Changes

Related issues/PRs

Uh oh!

iamteapot422 left a comment

Choose a reason for hiding this comment

Uh oh!

iamteapot422 Feb 22, 2026

Choose a reason for hiding this comment

Uh oh!

rohitkulkarni97 Feb 22, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

iamteapot422 commented Feb 22, 2026

Uh oh!

rohitkulkarni97 commented Feb 22, 2026

Uh oh!

rohitkulkarni97 commented Feb 22, 2026

Uh oh!

This comment was marked as resolved.

Uh oh!

iamteapot422 left a comment

Choose a reason for hiding this comment

Uh oh!

rohitkulkarni97 commented Feb 23, 2026

Uh oh!

rohitkulkarni97 commented Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iamteapot422 commented Feb 24, 2026

Uh oh!

iamteapot422 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

rohitkulkarni97 commented Feb 23, 2026 •

edited

Loading