Skip to content

Fix: crafting null reference when hand is empty#1499

Merged
iamteapot422 merged 2 commits intoRE-SS3D:developfrom
Dyhr:fix/crafting-null-reference
Feb 25, 2026
Merged

Fix: crafting null reference when hand is empty#1499
iamteapot422 merged 2 commits intoRE-SS3D:developfrom
Dyhr:fix/crafting-null-reference

Conversation

@Dyhr
Copy link
Contributor

@Dyhr Dyhr commented Feb 20, 2026

Summary

I found a simple bug, a null reference in the crafting system being thrown when interacting with the lockers with an open hand.

I also added some related logging.

Some related formatting issues was also committed.

I found two things that may or may not be worth turning into issues:

  • Running an interaction currently ray traces 3 times because the ray trace is used to find the interactions, first to check if you can do the interaction on the client, then the server verifies that the client can do the interaction, then the client needs to find the interaction again one last time. I'd consider sending changing the protocol so the information on the source and target objects are sent to the server so the raycast only happens to find what you're clicking on, not to find out what interactions are available.
  • The "GetGameObject()" method on IInteractionTarget is unintuitive, because some targets have game objects, but do not implement the optional IGameObjectProvider, making it unclear what the purpose of it is.

PR checklist

  • The game builds properly without errors.
  • No unrelated changes are present.
  • No "trash" files are committed.
  • Relevant code is documented.
  • Update the related GitBook document, or create a new one if needed.

@Dyhr Dyhr changed the title Fix/crafting null reference Fix: crafting null reference Feb 20, 2026
@Dyhr Dyhr changed the title Fix: crafting null reference Fix: crafting null reference when hand is empty Feb 20, 2026
Copy link
Contributor

@iamteapot422 iamteapot422 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@iamteapot422 iamteapot422 merged commit 423f1d7 into RE-SS3D:develop Feb 25, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants