-
Notifications
You must be signed in to change notification settings - Fork 2
Modified Unit-tests so that they always report scores using '.' as decimal separator #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Erechtheus
wants to merge
8
commits into
READ-BioMed:master
Choose a base branch
from
Erechtheus:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
9b5d6f5
Modified Unit-tests so that they always report scores using '.' as de…
Erechtheus db1afcd
Set Locale to english
Erechtheus 500857d
Set CSV as default
Erechtheus 14fd6a8
Change output to CSV like
Erechtheus 3b64f0e
Added link to original repository
Erechtheus 97d735a
Specific changes to prepare output as expected by codalab
Erechtheus 10c6a86
Added parameter -o and -outputfolder to specify the target folder to …
Erechtheus 833d2df
Renamed variables
Erechtheus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,5 @@ | ||
| ### This is a fork of [brateval](https://github.com/READ-BioMed/brateval). | ||
|
|
||
| # BRAT-Eval v0.3.2 | ||
|
|
||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,12 +26,13 @@ public enum OutFmt { | |
| } | ||
|
|
||
|
|
||
| public OutFmt outFmt = OutFmt.PLAIN; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is another breaking changes from what we have. |
||
| public OutFmt outFmt = OutFmt.CSV; | ||
|
|
||
| // options related to annotation folders | ||
| public String goldFolder; // name of folder for gold standard annotations | ||
| public String evalFolder; // name of folder for annotations to be compared to gold standard | ||
| public String configFile; // location/name of annotation.conf file (path + name) [by default, "annotation.conf" in the current directory will be used] | ||
| public String outputFolder; | ||
|
|
||
| // options related to matching | ||
| public MatchType matchType; // specify how spans are treated for matching | ||
|
|
@@ -50,6 +51,7 @@ public Options(String [] argv) { | |
| goldFolder = null; | ||
| evalFolder = null; | ||
| configFile = "annotation.conf"; | ||
| outputFolder=""; | ||
|
|
||
| for (int j=0; j<argv.length; ++j) { | ||
| if (argv[j].charAt(0) == '-') { | ||
|
|
@@ -99,6 +101,10 @@ else if (spanSelection.equalsIgnoreCase("exact") || spanSelection.equalsIgnoreCa | |
| typeSelection = "HIERARCHICAL"; | ||
| matchType.setTypeMatchType(TypeMatch.valueOf(toEnumName(typeSelection))); | ||
| break; | ||
| case "-o" : case "-outputfolder": | ||
| j++; | ||
| outputFolder = argv[j]; | ||
| break; | ||
| default: | ||
| throw new IllegalArgumentException("Unsupported option" + argv[j]); | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That will create incompatibility with any code that uses or expects this format. We use brateval internally in a project and I can assure this will break out code.
Nevertheless, I know what is the problem. The problem is that our code does not allow an easy way to override output format. I am going to create a new issue to track this.