Add umanaged transports#8
Merged
dmartinol merged 20 commits intoRHEcosystemAppEng:mainfrom Nov 4, 2025
Merged
Conversation
- Add MCPTransport abstract base class with standardized interface - Refactor JSONRPCTransport to StdioTransport implementing MCPTransport - Update ValidationContext to use MCPTransport interface - Add new fields for HTTP transport support (endpoint, transport_type) - Maintain backward compatibility via JSONRPCTransport alias - Add proper transport cleanup with close() method This establishes the foundation for supporting multiple transport types including the planned HTTP and SSE transports while keeping all existing functionality intact. 🤖 Generated with [Claude Code](https://claude.ai/code) Signed-off-by: Daniele Martinoli <dmartino@redhat.com> Co-authored-by: Claude <noreply@anthropic.com>
- Introduce HTTP transport implementation for MCP communication, allowing for HTTP-based interactions. - Update argument parser to include transport options and validate endpoint URLs. - Refactor validation orchestrator to support both stdio and HTTP transports, ensuring proper cleanup and initialization. - Add transport factory for creating transport instances based on type, enhancing modularity and maintainability. This update lays the groundwork for more flexible communication methods in MCP validation, improving usability and integration capabilities. Signed-off-by: D. Martinoli <dmartino@redhat.com> Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
- use mcp package - linting code - auth options Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
- exposed tools to security check Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
- Add complete HTTP transport implementation using MCP SDK's streamablehttp_client - Support three authentication strategies: * OAuth 2.0 Dynamic Client Registration (RFC 7591) - automatic * Pre-registered OAuth applications - manual setup * Personal access tokens - direct authentication - Implement OAuth callback server with automatic browser opening - Add pre-flight authentication checks to avoid SDK crashes - Update CLI to display authentication method being used - Enable context sharing between validators for accurate tool counts - Add comprehensive OAuth documentation to README Successfully tested with GitLab's MCP endpoint discovering 10 tools: get_pipeline_jobs, get_issue, create_issue, create_merge_request, get_merge_request, and 5 more GitLab MCP tools. 🤖 Generated with [Claude Code](https://claude.ai/code) Signed-off-by: Daniele Martinoli <dmartino@redhat.com> Co-authored-by: Claude <noreply@anthropic.com>
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
|
While running against the GitLab MCP server: A few thoughts:
|
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
…xist" was actually correct behavior being logged unnecessarily Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
…g until the right request ID is received Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
…quest" when the server silently ignores the malformed request (which is acceptable behavior). Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
Collaborator
Author
|
Hey @caxu-rh thanks for your comments. |
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
Collaborator
Author
|
@caxu-rh do you agree to merge? |
caxu-rh
approved these changes
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to address #5 and other structural updates.
Python Version & Dependencies
MCP Specification Compliance
CLI Interface Review
Transport System Complete Rewrite
--transport sse,--transport http) with CLI supportEnhanced Error Handling & Debugging
Documentation Updates