Skip to content

at86rf2xx/at86rf2xx_netdev: improve documentation.#10418

Merged
miri64 merged 1 commit intoRIOT-OS:masterfrom
Josar:pr/at86rf2xx_framebuffer_doc
Nov 17, 2018
Merged

at86rf2xx/at86rf2xx_netdev: improve documentation.#10418
miri64 merged 1 commit intoRIOT-OS:masterfrom
Josar:pr/at86rf2xx_framebuffer_doc

Conversation

@Josar
Copy link
Contributor

@Josar Josar commented Nov 16, 2018

It was not obvious where dev->idle_state was saved. This may lead to confusion.

#10291

It was not obvious where `dev->idle_state` was saved.
@Josar Josar force-pushed the pr/at86rf2xx_framebuffer_doc branch from 7aa6176 to 8e7c6cc Compare November 16, 2018 17:53
Copy link
Member

@jnohlgard jnohlgard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind adding some extra details in the code comments if it helps a developer understand the code better. ACK

@jnohlgard jnohlgard added Area: network Area: Networking Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels Nov 17, 2018
@jnohlgard jnohlgard added this to the Release 2019.01 milestone Nov 17, 2018
@miri64 miri64 merged commit 2b9134d into RIOT-OS:master Nov 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: drivers Area: Device drivers Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants