Skip to content

boards/sodaq-sara-aff: Initial support#10435

Merged
PeterKietzmann merged 1 commit intoRIOT-OS:masterfrom
leandrolanzieri:pr/boards/sodaq_sara_r410m
Dec 3, 2018
Merged

boards/sodaq-sara-aff: Initial support#10435
PeterKietzmann merged 1 commit intoRIOT-OS:masterfrom
leandrolanzieri:pr/boards/sodaq_sara_r410m

Conversation

@leandrolanzieri
Copy link
Contributor

Contribution description

This PR adds the initial support for the SODAQ SARA AFF boards (R410M and N211).

The hardware includes:

  • ublox SARA R4xx/N2xx NB-IoT module
  • ublox SAM M8Q GPS module
  • LSM303AGR accelerometer & magnetometer module
  • Solar charge controller

Right now we don't have drivers for the on-board modules.

Testing procedure

Follow the instructions in the Flash the board section of the documentation to test this.

Issues/PRs references

None

@leandrolanzieri leandrolanzieri added Type: new feature The issue requests / The PR implemements a new feature for RIOT Area: boards Area: Board ports labels Nov 20, 2018
@leandrolanzieri leandrolanzieri self-assigned this Nov 20, 2018
@aabadie
Copy link
Contributor

aabadie commented Nov 20, 2018

Nice one @leandrolanzieri ! Do you plan to work on the NB-IoT drivers ?

@leandrolanzieri
Copy link
Contributor Author

Nice one @leandrolanzieri ! Do you plan to work on the NB-IoT drivers ?

@aabadie yes! I'm starting with some tests now and I plan to work on the driver afterwards.

Copy link
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have the hardware for testing but codewise it looks already good and configured things match the datasheet.
Just one comment regarding LED0, see below.

@smlng
Copy link
Member

smlng commented Nov 30, 2018

@aabadie is this good to go?

@aabadie
Copy link
Contributor

aabadie commented Nov 30, 2018

is this good to go?

Not really, the first question of this #10435 (comment) is still not addressed and I haven't this hardware for testing. But I guess someone on your side can do the testing.

@leandrolanzieri
Copy link
Contributor Author

Not really, the first question of this #10435 (comment) is still not addressed

Sorry, missed that. Now it's changed.

@PeterKietzmann
Copy link
Member

I'll do some tests for the configured peripherals

@PeterKietzmann
Copy link
Member

Besides one minor exception (commented inline) all tests went smooth.

  • tests/shell
  • tests/leds (with AUTO_INIT_LED0 defined)
  • tests/periph_gpio (verified with LEDs)
init_out 0 12
toggle 0 12
  • tests/periph_adc (ADC_LINE(8) not accessible)
  • tests/periph_spi (verified with logic analyzer and MISO/MOSI bridge)
init 0 0 2 0 23
send hello
  • tests/driver_srf08 (for I2C)
  • tests/periph_timer
  • tests/periph_rtc, tests/periph_rtt
  • tests/xtimer_usleep (verified with logic analyzer, not super accurate but seems legit)
  • examples/saul (verified with LEDs) -> minor change request

@PeterKietzmann PeterKietzmann added Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels Nov 30, 2018
@PeterKietzmann
Copy link
Member

@leandrolanzieri please address squash immediately after addressing my comment. @aabadie would you remove your change request?

@leandrolanzieri leandrolanzieri force-pushed the pr/boards/sodaq_sara_r410m branch from feafad5 to 1e6282b Compare November 30, 2018 17:20
@leandrolanzieri
Copy link
Contributor Author

@PeterKietzmann done

@PeterKietzmann PeterKietzmann added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Dec 3, 2018
@PeterKietzmann
Copy link
Member

examples/lua_REPL and tests/unittests need some blacklisting due to insufficient ram. @aabadie mind to remove your change request?

@leandrolanzieri leandrolanzieri force-pushed the pr/boards/sodaq_sara_r410m branch from 1e6282b to d53fbb0 Compare December 3, 2018 09:06
@PeterKietzmann PeterKietzmann merged commit c834937 into RIOT-OS:master Dec 3, 2018
@aabadie aabadie added this to the Release 2019.01 milestone Dec 19, 2018
/** @} */

/**
* @name NB-IoT SARA module
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can a driver for this be found in some branch somewhere?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started doing one here. Basic functionalities but is working last time I checked.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you plan to PR it ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is interest I can make it PR ready with the current features

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there certainly is. Maybe @keestux could be interested.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was looking into possible mobile uplinks for RIOT and found #10086 and this.

Having a PR probably won't hurt so this is not forgotten

@leandrolanzieri leandrolanzieri deleted the pr/boards/sodaq_sara_r410m branch June 19, 2020 11:59
@keestux
Copy link
Contributor

keestux commented Jun 19, 2020

BTW I am co-author of the Arduino libraries for these Ublox modems [1]. (Notice how I squeezed in the company name, just like Adafruit and others.))

Having drivers in RIOT is/was on my todo/wish list. And ultimately, be able to actually write applications with RIOT instead of the horrible Arduino.

I was wondering if it was worthwhile to convert these (C++) libraries into RIOT drivers. There's a lot of code to be re-used.

[1] https://github.com/SodaqMoja/Sodaq_R4X, https://github.com/SodaqMoja/Sodaq_N2X, https://github.com/SodaqMoja/Sodaq_3Gbee

@benpicco
Copy link
Contributor

It should be possible to use Arduino libraries in RIOT #12518
But a 'native' driver would probably integrate better, I don't know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: boards Area: Board ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: new feature The issue requests / The PR implemements a new feature for RIOT

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants