boards/flash.sh: rename HEXFILE to BINFILE#10471
Merged
jcarrano merged 1 commit intoRIOT-OS:masterfrom Nov 27, 2018
Merged
Conversation
Flasher are doing 'loadbin' so use BINFILE name.
cladmi
added
State: waiting for other PR
This was referenced Nov 26, 2018
Contributor
Author
|
I just noticed that instead of updating these scripts, the boards could just be updated to use the common |
Contributor
Author
|
But as I do not have the boards and even JlinkExe (when installing from https://www.segger.com/downloads/jlink/#J-LinkSoftwareAndDocumentationPack it was called |
cladmi
added
CI: ready for build
jcarrano
approved these changes
Nov 27, 2018
Contributor
jcarrano
left a comment
jcarrano
left a comment
There was a problem hiding this comment.
Tested (no JLinkExe, but it should not matter.)
Contributor
|
As a side comment, that command line argument handling in |
Contributor
Author
|
It is used as an internal script only, so I think it is not needed to not do an extensive testing on arguments. |
miri64
added
the
Type: cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Flasher are doing 'loadbin' so use BINFILE name.
In
Makefile.includeit is already setting HEXFILE to BINFILERIOT/boards/cc2538dk/Makefile.include
Line 34 in ce8815f
RIOT/boards/common/remote/Makefile.include
Line 28 in ce8815f
Testing procedure
Try flashing for
cc2538dkor boards depending onremote/common:You should get the same output for
masterand this PR with:WARNING: by testing this, I noticed boards depending on
remote/commoncannot flash usingPROGRAMMER==jlinksince4bcb353#diff-5143693651d6b10f67f159d2f8f11d47EDIT issue was even older it was already broken by 8d07c01#diff-9f122f733b5127db6637053c7f2bbd4fI should do a PR to fix this before this one…
PR in #10472
Issues/PRs references
Split from these PRs that try to declare
BINFILEandFLASHFILEvariables.hexand.binfile and add FLASHFILE variable #8838