Skip to content

backport: 2018.10 compile fixes#10758

Closed
kaspar030 wants to merge 53 commits intoRIOT-OS:masterfrom
kaspar030:2018.10-compile-fixes
Closed

backport: 2018.10 compile fixes#10758
kaspar030 wants to merge 53 commits intoRIOT-OS:masterfrom
kaspar030:2018.10-compile-fixes

Conversation

@kaspar030
Copy link
Contributor

Contribution description

Backport of some compile fixes from master.

  1. jerryscript warning disable for llvm
  2. nimble warning disable for llvm
  3. tinycrypt commit hash update

Testing procedure

Compilation by CI should be sufficient.

Issues/PRs references

Needed to make #10757 pass CI.

aabadie and others added 30 commits October 29, 2018 12:12
nrf52840dk and microbit

(cherry picked from commit a3f2d20)
Errors flags could not clear making the i2c unusable after error.
This fix removes the error check in start so the error flags can clear and does proper checking for status bits before _bus_check.
…archi

makefile.iotlab.single.inc.mk: add new supported nodes [backport 2018.10]
When building from a worktree, the common git directory was not mounted
in docker.

This lead to the version not being set and issues with git-cache in
ubuntu bionic that could not execute the 'git hash-object' command.

(cherry picked from commit 61a3e5d)
drivers/at: fix invalid function pointer cast [backport 2018.10]
 cpu/stm32_common/i2c: Fix error handling in i2c_1.c [backport 2018.10]
…le_2018.10

example/nanocoap: fix block2 example [backport 2018.10]
…/docker/handle_worktree

makefiles/docker.inc.mk: handle building in git worktree [backport 2018.10]
This fixes building an example that is outside of RIOT with docker and
also fixes building from a release archive.
…ect_is_appdir

Makefile.include: Fix BUILDRELPATH when RIOTPROJECT is CURDIR [backport 2018.10]
 - the driver for sht1x is initialized two times
 - the second initialization is done only when SAUL is used, but sht1x needs
   to be initialized in any case. (SAUL registration is also done there, but
   only when SAUL is actually being used.)

This commit fixes both.
The auto initialization of the sht1x module differs from the initialization of
other sensors, but previously no documentation pointed that out. This lack of
documentation led to a bug being introduced. This commit provides the previously
missing documentation.
Removes architecture specific includes from documentation of module  Peripheral Driver Interface / GPIO.
Removes architecture specific includes from documentation of module  Peripheral Driver Interface / GPIO.
…n_fix

cpu/esp32: doxygen fix [backport 2018.10]
…en_fix

cpu/esp8266: doxygen fix [backport 2018.10]
sys/auto_init: Fixed initialization of sht1x [backport 2018.10]
The current test implementation wrongly assumes that the diff between
two fired events (e1, e2) must always increase. That is not true, as
event e1 may reside on the upper part of [I/2, I) and e2 on the lower
part of [I, 2*I).

This commit fixes the test to look at the actual time that was randonmly
chosen from both intervals (t1, t2). Given that the intervals are
doubled, t1 must always be smaller than t2.
test: trickle: fix condition for success [backport 2018.10]
The `src` member of `sock_udp_t` for `emb6` is a pointer, not a value,
so it should not be referenced.

This fixes the output issue encountered during the
[2018.10 RC1 testing][RC1].

[RC1]: RIOT-OS/Release-Specs#76 (comment)

(cherry picked from commit 0d5dafe)
jia200x and others added 22 commits November 6, 2018 13:23
…x/sock-info-src

emb6_sock_udp: copy receive remote correctly [backport 2018.10]
`_decapsulate()` is called by callees of `_receive()` so the call to
the latter function within the first creates a recursion we don't want.
Using `gnrc_netapi` instead removes that and provides the added benefit
that other subscribers to IPv6 are also informed.

(cherry picked from commit 160ccbc)
Otherwise, an encapsulated IPv6 packet is handled twice. Once in the
central function, once in the specialized decapsulation.

(cherry picked from commit d54ac38)
…v6/fix/encaps-ipv6-recursion

gnrc_ipv6: don't recurse into receive for encapsulated IPv6 [backport 2018.10]
…x/llvm-static-analyzer2

gnrc_ipv6_nib: fix several issues found with LLVM's static code analyzer (only critical) [backport 2018.10]
Without this the first packet to a new link-local address will not be
delivered in non-6Lo environments, since the interface is not provided.
With this change, if an internet was provided to the address resolver it
will be stored within an allocated `gnrc_netif_hdr_t`.

At this point [IPv6 already striped](netif strip) the packet of its
netif header, so there is no risk that there will be to, in case it was
provided and the `netif` came from its existence.

(cherry picked from commit ce0c468)
…v6_nib/fix/netif_queued

gnrc_ipv6_nib: provide interface on packet queueing [backport 2018.10]
sock_[udp|ip]_recv returns `pkt->size` after pkt was released via `gnrc_pktbuf_release(pkt)`.
This can result in wrong values returned by this functions and thus is not according to its sepecification.

Storing this values before releasing pkt returning the stored values should fix this.

(cherry picked from commit e904706)
…p_use_after_free

gnrc_sock_[udp|ip]: read return value for _recv after release [backport 2018.10]
Return value was ignored but function could fail

(cherry picked from commit f0e785a)
RFC3610 states that len_encoding is only valid for "0x0001 ... 0xFEFF"

   If 0 < l(a) < (2^16 - 2^8), then the length field is encoded as two
   octets which contain the value l(a) in most-significant-byte first
   order.

(cherry picked from commit 3fd8276)
Maximal supported value is 0xFEFF.

(cherry picked from commit 147390c)
…to/ccm/auth_data_len_upper_bound

crypto/ccm: fix auth_data_len check [backport 2018.10]
release-notes.txt: Add Release 2018.10 notes [backport 2018.10]
Upstream rewrote history in master which changed our reference commit from

    intel/tinycrypt@3ea1a60

to

    intel/tinycrypt@6a22712

Diff can be verified to be empty with:

    intel/tinycrypt@6a22712...3ea1a60
@kaspar030 kaspar030 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: release backport Integration Process: The PR is a release backport of a change previously provided to master labels Jan 12, 2019
@kaspar030 kaspar030 requested a review from miri64 January 12, 2019 16:40
@kaspar030
Copy link
Contributor Author

Ups, this was a PR to the wrong branch.

@kaspar030 kaspar030 closed this Jan 12, 2019
@aabadie
Copy link
Contributor

aabadie commented Jan 12, 2019

No need to close the PR, just change the target branch (edit the PR title and you change that from there).

@miri64
Copy link
Member

miri64 commented Jan 12, 2019

@aabadie there is already an alternative @ #10759

@aabadie
Copy link
Contributor

aabadie commented Jan 12, 2019

there is already an alternative

there was a race when I posted the message and tried to do it myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: release backport Integration Process: The PR is a release backport of a change previously provided to master

Projects

None yet

Development

Successfully merging this pull request may close these issues.