pkg/jerryscript: namespace BUILD_DIR variable#10789
Merged
miri64 merged 1 commit intoRIOT-OS:masterfrom Jan 16, 2019
Merged
Conversation
BUILD_DIR was introduced but the variable was already used by `pkg/jerryscript` so there is a name collision. Namespace it to prevent issues.
miri64
approved these changes
Jan 16, 2019
Member
miri64
left a comment
There was a problem hiding this comment.
ACK straight forward change and jerryscript still compiles.
Contributor
Author
|
Thanks for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
I forgot to git grep when merging
BUILD_DIRand I found issues about it.BUILD_DIR was introduced but the variable was already used by
pkg/jerryscriptso there is a name collision.Namespace it to prevent issues.
Testing procedure
Build
examples/javascriptand thebuilddirectory should not be created, and the archives will be generated inexamples/javascript/bin/native/jerryscript/lib/When building in docker,
buildwill be created but empty.There is no more other usages now in the repository:
Issues/PRs references
Original PR #10038