Skip to content

pkg/jerryscript: namespace BUILD_DIR variable#10789

Merged
miri64 merged 1 commit intoRIOT-OS:masterfrom
cladmi:pr/build_dir/fix_jerryscript
Jan 16, 2019
Merged

pkg/jerryscript: namespace BUILD_DIR variable#10789
miri64 merged 1 commit intoRIOT-OS:masterfrom
cladmi:pr/build_dir/fix_jerryscript

Conversation

@cladmi
Copy link
Contributor

@cladmi cladmi commented Jan 16, 2019

Contribution description

I forgot to git grep when merging BUILD_DIR and I found issues about it.

BUILD_DIR was introduced but the variable was already used by
pkg/jerryscript so there is a name collision.
Namespace it to prevent issues.

Testing procedure

Build examples/javascript and the build directory should not be created, and the archives will be generated in examples/javascript/bin/native/jerryscript/lib/
When building in docker, build will be created but empty.

There is no more other usages now in the repository:

git grep '(BUILD_DIR)'
Makefile.include:override BUILD_DIR      := $(abspath $(BUILD_DIR))
makefiles/docker.inc.mk:        $(Q)mkdir -p $(BUILD_DIR)
makefiles/docker.inc.mk:            -v '$(BUILD_DIR):$(DOCKER_BUILD_ROOT)/build' \

Issues/PRs references

Original PR #10038

BUILD_DIR was introduced but the variable was already used by
`pkg/jerryscript` so there is a name collision.
Namespace it to prevent issues.
@cladmi cladmi added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: build system Area: Build system Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jan 16, 2019
@cladmi cladmi requested a review from smlng January 16, 2019 16:57
@cladmi cladmi added this to the Release 2019.01 milestone Jan 16, 2019
Copy link
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK straight forward change and jerryscript still compiles.

@miri64 miri64 merged commit d4b92e9 into RIOT-OS:master Jan 16, 2019
@cladmi
Copy link
Contributor Author

cladmi commented Jan 16, 2019

Thanks for the review.

@cladmi cladmi deleted the pr/build_dir/fix_jerryscript branch January 16, 2019 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: build system Area: Build system Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants