Skip to content

[WIP] Fixes to compile using DOCKER and flash boards without local toolchain#10870

Closed
cladmi wants to merge 1 commit intoRIOT-OS:masterfrom
cladmi:pr/wip/paperci
Closed

[WIP] Fixes to compile using DOCKER and flash boards without local toolchain#10870
cladmi wants to merge 1 commit intoRIOT-OS:masterfrom
cladmi:pr/wip/paperci

Conversation

@cladmi
Copy link
Contributor

@cladmi cladmi commented Jan 25, 2019 •
edited by fjmolinas
Loading

Contribution description

I am working to run https://github.com/RIOT-OS/RIOT/blob/master/dist/tools/compile_and_test_for_board/compile_and_test_for_board.py on a machine with several boards connected and without local board specific toolchain installed. It only has some native compilation tools, relies on docker for building, has local flashers and python dependencies for running the tests.

This branch follows all the changes I found I needed to achieve this. The goal is not to merge this but to be split in several dedicated PRs.

Feel free to split some commits out of here if you want them before I do a dedicated PR.

Current boards being tested

arduino-mega2560 frdm-k64f frdm-kw41z msba2 mulle nrf52dk pba-d-01-kw2x sltb001a stm32f3discovery

Sub pull requests

Not a fix, but to be in a closer setup to the RIOT CI and ready to use in the future:

Open issues

Testing procedure

Compile, flash and test for some boards without any toolchain installed on your machine except the one needed to build flashers, objdump/objcopy, docker.

Issues/PRs references

Preparing a test setup for the release tests and different weekly ci testing in general.
#10857

@cladmi cladmi added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable Area: build system Area: Build system Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Area: tools Area: Supplementary tools Type: tracking The issue tracks and organizes the sub-tasks of a larger effort labels Jan 25, 2019
@cladmi cladmi requested a review from aabadie January 25, 2019 16:33
@cladmi cladmi force-pushed the pr/wip/paperci branch 2 times, most recently from 01b823b to a73209b Compare January 25, 2019 16:59
@cladmi cladmi mentioned this pull request Jan 28, 2019
Merged
@cladmi cladmi added the State: waiting for other PR State: The PR requires another PR to be merged first label Jan 28, 2019
@cladmi cladmi requested a review from jcarrano February 7, 2019 13:29
@cladmi cladmi mentioned this pull request Feb 11, 2019
Merged
1 task
@cladmi cladmi force-pushed the pr/wip/paperci branch 2 times, most recently from 9e32368 to 219f22c Compare February 22, 2019 17:24
@cladmi cladmi mentioned this pull request Feb 26, 2019
Closed
@cladmi
Copy link
Contributor Author

cladmi commented Feb 26, 2019

I found out that flashing driver_adt7310 breaks flashing on some frdm boards.
It breaks the frdm-k64f in the middle of the flash and the frdm-kw41z after the first flash.

I do not blame the firmware but the flasher that does not handle flashing in some state.

@cladmi
Copy link
Contributor Author

cladmi commented Feb 26, 2019

The issue with the frdm-kw41z may also be important for IoT-LAB @aabadie

@cladmi
Copy link
Contributor Author

cladmi commented Feb 26, 2019

And I can recover the board by flashing using the drag-and-drop mode.

@cladmi cladmi force-pushed the pr/wip/paperci branch 2 times, most recently from 8e5854f to 754139c Compare March 14, 2019 14:27
This was referenced Mar 14, 2019
Merged
Merged
Closed
@cladmi cladmi changed the title [WIP] Fixes to compile and flash boards using DOCKER [WIP] Fixes to compile using DOCKER and flash boards without local toolchain Mar 23, 2019
@cladmi cladmi mentioned this pull request Aug 22, 2019
Merged
@cladmi cladmi force-pushed the pr/wip/paperci branch 4 times, most recently from 2aa77a0 to 97165ec Compare September 2, 2019 13:56
@cladmi cladmi force-pushed the pr/wip/paperci branch 9 times, most recently from caeda25 to fa4dec3 Compare September 12, 2019 14:54
@cladmi cladmi mentioned this pull request Sep 17, 2019
Merged
@cladmi cladmi force-pushed the pr/wip/paperci branch 3 times, most recently from 0fcbcc1 to 6351f58 Compare September 25, 2019 09:32
@cladmi cladmi force-pushed the pr/wip/paperci branch 2 times, most recently from d9fea6f to 9d440eb Compare October 1, 2019 15:55
@kb2ma kb2ma removed this from the Release 2019.10 milestone Oct 9, 2019
@cladmi cladmi mentioned this pull request Oct 10, 2019
Merged
@cladmi @miri64
cpu/esp32: FIX use esptool.py from path
5046140 
This allows flashing using `esptool.py` install from pip.

The documentation already state that `esptool.py` must be put available
in the path and that it is possible to use the `pip` version.
@miri64
Copy link
Member

miri64 commented Nov 21, 2019

Rebased to current master so https://ci-ilab.imp.fu-berlin.de works again with 9080893 being merged (not sure this PR is still necessary with that change though)

@miri64
Copy link
Member

miri64 commented Nov 21, 2019

(not sure this PR is still necessary with that change though)

If not, maybe someone from @riot-appstore can make sure that the rebase to this PR does not happen anymore at the builds there. Not sure I have the administrative rights for that.

@miri64
Copy link
Member

miri64 commented Nov 21, 2019

Still doesn't work with the current config. I can't reproduce the merge conflict there with my local machine anymore though.

@fjmolinas
Copy link
Contributor

fjmolinas commented Jan 3, 2020

@miri64 I think this one can be closed, #12003 already addresses the remaining issue.

@fjmolinas
Copy link
Contributor

fjmolinas commented Jan 12, 2020

Closing since #12750 fixes the last remaining fix in this PR and #12003 addresses the riotboot issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aabadie aabadie Awaiting requested review from aabadie

@jcarrano jcarrano Awaiting requested review from jcarrano

Assignees

No one assigned

Labels

Area: build system Area: Build system Area: tools Area: Supplementary tools CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable State: waiting for other PR State: The PR requires another PR to be merged first State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Type: tracking The issue tracks and organizes the sub-tasks of a larger effort

Projects

None yet

Milestone

Release 2020.01

Development

Successfully merging this pull request may close these issues.

4 participants

@cladmi @miri64 @fjmolinas @kb2ma