Conversation
82675ea to
d023c52
Compare
4cf243b to
ad90067
Compare
|
I added a commit with my contributions. I detailed to what tasks they are related to in the commit message. |
328c69f to
1f0a1fe
Compare
35f6229 to
e80f43a
Compare
release-notes.txt
Outdated
| About 387 pull requests with about 912 commits have been merged since the last | ||
| release and about 36 issues have been solved. 54 people contributed with code | ||
| in 92 days. Approximately 1525 files have been touched with 171769 insertions | ||
| and 46121 deletions. |
There was a problem hiding this comment.
Are these numbers recent or just copy-pasted?
There was a problem hiding this comment.
a quick check here shows more like 425 PRs merged, and 1285 commits since the 2018.10 release (on Nov. 13th, right?)
I used the below methods, taking:
- for the merged PR count, this github API call
- for the number of commits, the below git command
$ git rev-list --after="2018-11-13T00:00" --count master
There was a problem hiding this comment.
912 commits is right according to
./dist/tools/release-stats/release-stats.sh 2019.01-devel 2019.01-RC3But the rest is off a bit. The number of issues is also too small and we got 429 PRs merged
There was a problem hiding this comment.
Sorry, just saw your comment now ^^"
There was a problem hiding this comment.
The results of the release stats script were
<tr>
<td>2019.01-RC3</td>
<td>7131</td>
<td>2010903 (1914102)</td>
<td>110 days</td>
<td>912</td>
<td>1554 files changed, 176241 insertions(+), 50593 deletions(-)</td>
<td>199 Martine Lenders<br />
128 Alexandre Abadie<br />
112 Gunar Schorcht<br />
48 Gaëtan Harter<br />
48 Kees Bakker<br /></td>
</tr>btw. They are meant for this table. So fourth cell is the development time, fifth the number of commits, and sixth the diff stats.
Number of contributors can be counted with
$ git shortlog --no-merges -n -s "2019.01-devel".."2019.01-RC3" | wc -l
54
There was a problem hiding this comment.
git rev-list --after="2018-11-13T00:00" --count master
This method also includes things that are already merged in master but not backported to the release branch. To get the number of PRs I used the PR listed in GitHub but filtered on the Milestone 2019.01. I tried to include everything I could but maybe some were missed.
The number of issues is also too small
because it only includes the issues labelled as bug.
There was a problem hiding this comment.
About the number of files touched and global changeset, I did:
$ git diff --shortstat 2019.01-devel..2019.01-RC3
1525 files changed, 171769 insertions(+), 46121 deletions(-)
There was a problem hiding this comment.
I updated the number of days. Do we agree with the other numbers ?
There was a problem hiding this comment.
About git diffstats, dist/tools/release-stats/release-stats.sh uses the --no-renames option. IIUC, with this, the statistics also includes files that were just renamed. Why not, so I'll update the values.
|
@aabadie just added a synopsis (last explicit TO DO left here ;) |
|
@emmanuelsearch, @miri64, last thing we need is a review here before the release. |
| Cortex-M boards supported by RIOT. Support for several new boards and new sensors | ||
| was added, as well as for the new CPU architecture Armv8-M (Cortex-M23). Last | ||
| but not least, this release contains a number of bug fixes and enhances test | ||
| automation. |
There was a problem hiding this comment.
Assuming this paragraph is fine with everyone, I'm fine with this PR ;)
Co-authored-by: Emmanuel Baccelli <emmanuel.baccelli@inria.fr> Co-authored-by: Gaëtan Harter <gaetan.harter@fu-berlin.de> Co-authored-by: Martine Lenders <m.lenders@fu-berlin.de> Co-authored-by: Leandro Lanzieri <leandro.lanzieri@haw-hamburg.de> Co-authored-by: Peter Kietzmann <peter.kietzmann@haw-hamburg.de>
07a557e to
5cfdf0c
Compare
Done :) |
Well, we also need a backport of this ;) |
My comment was addressed. I'm fine with @emmanuelsearch's paragraph.
|
@miri64, since you co-authored the release note commit, you reach the 200 commits included in this release, congrats! |
|
Let's go! |
| About this release: | ||
| =================== | ||
|
|
||
| The 2019.01 release includes a number of new features including DMA support on |
There was a problem hiding this comment.
Sorry for my late review.
I think the IPv6 refactor should be also included. The project was finished during January, just before feature freeze
There was a problem hiding this comment.
Ok, it's not highlighted but it's added in the list of changes here. I think it's fine even if not perfect.
Contribution description
This PR is the initial draft for the 2019.01 release notes.
Every maintainer is invited to update this PR by either opening PRs against my fork or by directly pushing into my branch.
You can get the complete list of closed issues and PRs tagged for this release in https://github.com/RIOT-OS/RIOT/milestone/25?closed=1.