gnrc_icmpv6_echo: avoid crashing when pktbuf full [backport 2019.01]#10874
Merged
aabadie merged 1 commit intoRIOT-OS:2019.01-branchfrom Jan 26, 2019
Merged
gnrc_icmpv6_echo: avoid crashing when pktbuf full [backport 2019.01]#10874aabadie merged 1 commit intoRIOT-OS:2019.01-branchfrom
aabadie merged 1 commit intoRIOT-OS:2019.01-branchfrom
Conversation
Once the packet buffer is full on heavy network load, gnrc_netif_hdr_build may return NULL. In that case, the following unchecked access to hdr->data leads to a crash.
gschorcht
added
Type: bug
aabadie
added
CI: ready for build
Contributor
Author
|
@aabadie Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #10869
Contribution description
This PR fixes the unchecked access to
(gnrc_netif_hdr_t *)hdr->datawherehdris returned fromgnrc_netif_hdr_build. If packet buffer is full,gnrc_netif_hdr_buildmay returnNULL. The following unchecked access to the pointer can then lead to a crash.Testing procedure
Produce a lot of network traffic using ping command with maximum data size and an intervall of 0, if necessary from multiple terminals so that the packet buffer becomes full, e.g.
This test should not lead to a crash.
Issues/PRs references
Problem was found during testing PR #10862 and described in issue #10861.