Skip to content

release-notes.txt: Add Release 2018.10.1 notes [backport 2019.01]#11016

Merged
jia200x merged 1 commit intoRIOT-OS:2019.01-branchfrom
aabadie:backport/2019.01/pr/release_notes_2018_10_1
Feb 14, 2019
Merged

release-notes.txt: Add Release 2018.10.1 notes [backport 2019.01]#11016
jia200x merged 1 commit intoRIOT-OS:2019.01-branchfrom
aabadie:backport/2019.01/pr/release_notes_2018_10_1

Conversation

@aabadie
Copy link
Contributor

@aabadie aabadie commented Feb 14, 2019

Backport of #10924

Contribution description

This PR adds the (sub) Release 2018.10.1 notes.

It contains the list of merged PRs and commits in 2018.10-branch between 2018.10-devel tag and the #10285

Testing procedure

Read

Issues/PRs references

None so far

@aabadie aabadie added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Process: release cycle Integration Process: The PR is connected to the release cycle (e.g. release notes) labels Feb 14, 2019
@aabadie aabadie requested a review from miri64 February 14, 2019 16:32
@aabadie
Copy link
Contributor Author

aabadie commented Feb 14, 2019

This is not a joke. It is required otherwise the 2019.01 release notes cannot be backported smoothly on 2019.01-branch...

@miri64
Copy link
Member

miri64 commented Feb 14, 2019

This is not a joke. It is required otherwise the 2019.01 release notes cannot be backported smoothly on 2019.01-branch...

You seem surprised. ;-)

@miri64
Copy link
Member

miri64 commented Feb 14, 2019

Can't properly review right now, since I'm on a train and later will be unavailable until around midnight. @emmanuelsearch @jia200x can one of you review maybe?

@aabadie aabadie requested review from cladmi and jia200x February 14, 2019 18:42
@jia200x
Copy link
Member

jia200x commented Feb 14, 2019

Commit matches. All OK

Copy link
Member

@jia200x jia200x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@jia200x jia200x merged commit 46b7f68 into RIOT-OS:2019.01-branch Feb 14, 2019
@aabadie
Copy link
Contributor Author

aabadie commented Feb 14, 2019

Thanks @jia200x !

@miri64
Copy link
Member

miri64 commented Feb 14, 2019

Can't properly review right now, since I'm on a train and later will be unavailable until around midnight. @emmanuelsearch @jia200x can one of you review maybe?

I didn't even realize that this was about 2018.10.1 so bad was my capability to review.

@miri64
Copy link
Member

miri64 commented Feb 15, 2019

This is not a joke. It is required otherwise the 2019.01 release notes cannot be backported smoothly on 2019.01-branch...

You seem surprised. ;-)

Honestly, now that I know that this was about 2018.10.1-branch I don't understand either. 2018.10.1-branch and 2019.01-branch should be independent from each other. What happened?

@aabadie
Copy link
Contributor Author

aabadie commented Feb 15, 2019

What happened?

The release notes were conflicting !

@miri64
Copy link
Member

miri64 commented Feb 15, 2019

But how? I mean this branch has nothing to do with 2019.01 so how did the backport help?

@miri64
Copy link
Member

miri64 commented Feb 15, 2019

Ahhh... this PR is not against the 2018.10.1-branch but backports the 2018.10.1 release notes to the 2019.01-branch. This makes sense, since 2018.10.1 was released after the feature freeze of 2019.01!

@aabadie aabadie deleted the backport/2019.01/pr/release_notes_2018_10_1 branch February 15, 2019 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Process: release cycle Integration Process: The PR is connected to the release cycle (e.g. release notes)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants