Skip to content

makefiles/serial: fix indent#11035

Merged
jcarrano merged 1 commit intoRIOT-OS:masterfrom
aabadie:pr/tools/serial_makefile_indent
Feb 20, 2019
Merged

makefiles/serial: fix indent#11035
jcarrano merged 1 commit intoRIOT-OS:masterfrom
aabadie:pr/tools/serial_makefile_indent

Conversation

@aabadie
Copy link
Contributor

@aabadie aabadie commented Feb 20, 2019

Contribution description

This PR is fixing the wrong indentation (4 spaces instead of 2) in makefiles/tools/serial.inc.mk.

Should be straightforward.

Testing procedure

Build/flash/term on any application should still work with pyterm and picocom

Issues/PRs references

Found while reviewing #11003 and playing with #11034

@aabadie aabadie added Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Area: tools Area: Supplementary tools labels Feb 20, 2019
@aabadie aabadie requested review from cladmi and jcarrano February 20, 2019 07:43
@cladmi cladmi added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Feb 20, 2019
Copy link
Contributor

@cladmi cladmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. I tested with samr21-xpro in examples/default with both pyterm and picocom.

You can merge when CI approves.

@jcarrano jcarrano merged commit 1335bf6 into RIOT-OS:master Feb 20, 2019
@danpetry danpetry added this to the Release 2019.04 milestone Mar 11, 2019
@aabadie aabadie deleted the pr/tools/serial_makefile_indent branch July 4, 2019 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants