[WIP] tests/test_tools: add a test for the testing tools environment#11094
Closed
cladmi wants to merge 3 commits intoRIOT-OS:masterfrom
Closed
[WIP] tests/test_tools: add a test for the testing tools environment#11094cladmi wants to merge 3 commits intoRIOT-OS:masterfrom
cladmi wants to merge 3 commits intoRIOT-OS:masterfrom
Conversation
cladmi
added
Type: bug
2 tasks
Contributor
Author
|
There is no need to currently review this, but it should be used as a base for testing a fix for |
1 task
cladmi
force-pushed
the
pr/test_tools/assert_term_does_not_local_echo
branch
from
ca9376e to
828499e
Compare
cladmi
force-pushed
the
pr/test_tools/assert_term_does_not_local_echo
branch
from
828499e to
1826c53
Compare
Check the interaction with a board through make term. It is using a shell without echo or prompt for reference. It currently checks that there is no local echo.
Get the output of a one line command without other garbage messages.
I know this does not work for boards that overwrite 'TERMFLAGS', it is not a fix, just a hack to show what is expected.
cladmi
force-pushed
the
pr/test_tools/assert_term_does_not_local_echo
branch
from
1826c53 to
a998291
Compare
This was referenced Aug 23, 2019
Member
|
Could still be valuable. Anyone willing to pick up @cladmi's work? @leandrolanzieri @fjmolinas @aabadie? |
Contributor
Author
|
I think everything is already in https://github.com/RIOT-OS/RIOT/blob/master/tests/test_tools/tests/01-run.py. The tests were merged along the bug fixes. The "increment" from here was replaced by an "uppercase" as there were issues with matching numbers in pyterm output, but the check is the same. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Check the interaction with a board through make term.
It is using a shell without echo or prompt for reference.
It currently checks:
Warning
This is currently not ready for merging as it is waiting for a fix on
make term.But it should show the issue. I removed the test from #10952 so made this pull request for tracking the issue.
Testing procedure
Testing on all the different environments.
There is currently a HACK for
picocomandpytermwhich should be correctly fixed.Issues/PRs references
Test split out of #10952 and depending on it.
Found while writing tests in #10949
Depends on : "adding make rawterm"