makefiles/modules.inc.mk: refactoring#11109
Merged
jcarrano merged 5 commits intoRIOT-OS:masterfrom Mar 11, 2019
Merged
Conversation
USEMODULE is already exported by `makefiles/vars.inc.mk`.
BASELIBS is used only in the main Makefile.include or included files. As it is not used in sub make executions or scripts it does not need to be exported.
Factorize the reused value in a private variable. I define it private as somehow 'USEPKG' is supposed to be removed so the variables can be removed later.
Put all lines related to CFLAGS handling together.
Refactor to define REALMODULES incrementally without overwriting 'NO_PSEUDOMODULES'. This also allows an external makefile to maybe add something there if it really needs to.
cladmi
added
Area: build system
Contributor
Author
|
I am currently comparing both outputs and will report any issues found. |
Contributor
Author
|
My test script finds no changed values: |
jcarrano
added
the
CI: ready for build
Contributor
Author
|
Thanks for the review. I will update the pull requests that depend on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This pull request does some refactoring in
makefiles/modules.inc.mk.$(sort $(USEMODULE) $(USEPKG))REALMODULESis definedTesting procedure
The value of
EXTDEFINESandREALMODULESshould be the same inmasterand this pull request for all applications and boards:I provided an automated test script for this:
https://gist.github.com/cladmi/9818888da7412a9195ec0d4c3c2a8b8a
Both output should not report any difference
There are currently
/bin/sh: 1: Syntax error: Missing '))'messages but they are unrelated.Issues/PRs references
I did this cleanup locally a long time ago to better understand this file, and now I want to use this as a pre-requisite to introducing
LIBSfor #11111#8711