Skip to content

sys/test_helper: Add test_helper module#11224

Closed
MrKevinWeiss wants to merge 3 commits intoRIOT-OS:masterfrom
MrKevinWeiss:pr/addtest_helper
Closed

sys/test_helper: Add test_helper module#11224
MrKevinWeiss wants to merge 3 commits intoRIOT-OS:masterfrom
MrKevinWeiss:pr/addtest_helper

Conversation

@MrKevinWeiss
Copy link
Contributor

Contribution description

This PR adds a test_helper module adds a collection of helpers used for shell based tests. Specifically it adds basic, lightweight json formatting, print_echo and collects module dependencies. This should make it easier to stick to a standard way of writing and reduce code duplication.

Testing procedure

make all -C tests/shell/ test

This commit adds a test_helper module that provides functions
to help with writing shell based tests. This should make it
easier to stick to a standard way of writing and reduce code
duplication.
This commit replaces the echo command and uses the
test_helper module in the shell test.
@MrKevinWeiss MrKevinWeiss added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet Area: tests Area: tests and testing framework Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer labels Mar 20, 2019
@MrKevinWeiss MrKevinWeiss self-assigned this Mar 20, 2019
@MrKevinWeiss MrKevinWeiss requested a review from smlng March 20, 2019 15:37
@MrKevinWeiss
Copy link
Contributor Author

@smlng should I also add an implementation with it (maybe the spi so it doesn't break the HiL)?

@MrKevinWeiss
Copy link
Contributor Author

I should maybe add a different pseudomodule that brings in the shell everything something like USEMODULE=test_helper_interactive or USEMODULE=test_helper_shell

@MrKevinWeiss MrKevinWeiss requested a review from cladmi March 26, 2019 13:40
@stale
Copy link

stale bot commented Sep 27, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions.

@stale stale bot added the State: stale State: The issue / PR has no activity for >185 days label Sep 27, 2019
@MrKevinWeiss MrKevinWeiss added the State: don't stale State: Tell state-bot to ignore this issue label Oct 1, 2019
@stale stale bot removed the State: stale State: The issue / PR has no activity for >185 days label Oct 1, 2019
@MrKevinWeiss
Copy link
Contributor Author

Implemented in RFtests but I don't want to close until some conclusion is reached.

@fjmolinas
Copy link
Contributor

@MrKevinWeiss would be nice to have this in a way where it could optionally be toogled on and off.

@MrKevinWeiss
Copy link
Contributor Author

I will try to get this up to speed when I come back to work next week.

@MrKevinWeiss
Copy link
Contributor Author

closed with #15950

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: tests Area: tests and testing framework Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer State: don't stale State: Tell state-bot to ignore this issue State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants