isrpipe: split isrpipe_read_timeout to isolate xtimer dependency

[cladmi]

Contribution description

This defines a new 'isrpipe_read_timeout' module that should be used when using
the timeout based function of isrpipe.

This fix the implicit dependency to 'xtimer' that is only needed for the
'_timeout' functions.

It prevents 'stdio_uart' that uses 'isrpipe' to need to depend on xtimer.
This was silently solved at link time for most platforms but not for the
'esp32' for example.

'drivers/at' needed to be updated at the same time to follow the api change.

Testing procedure

In master, the esp32 actually provides warning when compiling some of the applications regarding the missing xtimer symbols. But there are only handled as warnings (#11246)

RIOT_CI_BUILD=1 DOCKER="sudo docker" BOARD=esp32-wroom-32 BUILD_IN_DOCKER=1 make -C tests/pkg_cn-cbor/
...
make" -C /data/riotbuild/riotbase/tests/pkg_cn-cbor/bin/pkg/esp32-wroom-32/cn-cbor/src -f /data/riotbuild/riotbase/pkg/cn-cbor/Makefile.cn-cbor
/data/riotbuild/riotbase/tests/pkg_cn-cbor/bin/esp32-wroom-32/isrpipe.a(isrpipe.o): In function `isrpipe_read':
isrpipe.c:(.text+0x84): warning: undefined reference to `_xtimer_set'
isrpipe.c:(.text+0x88): warning: undefined reference to `xtimer_remove'
isrpipe.c:(.text+0xb2): warning: undefined reference to `_xtimer_set'
/data/riotbuild/riotbase/tests/pkg_cn-cbor/bin/esp32-wroom-32/isrpipe.a(isrpipe.o): In function `isrpipe_read_timeout':

With this pull request there is no reported error anymore. It also removes all the issues with isrpipe.c in #11246

Issues/PRs references

Part of enabling error at link time for esp #11246
It was found while trying to run the test suite on esp32.

[cladmi]

I am not that used to write module headers and the doxygen so I welcome feedback on this :)

I kept the original license as I was moving the functions around files, tell me if this is wrong.

[cladmi]

Note for me, I noticed a missing word in the first commit message (needs squashing label)

[miri64]

Note for me, I noticed a missing word in the first commit message (needs squashing label)

Please feel free to do so.

[miri64]

Except for the module doc I'm fine. The code and documentation of the functions was just copy-pasted.

[miri64]

This is just copy-pasted from isrpipe. You have two options here either remove the @defgroup and @brief tag and just do @ingroup isr_pipe or (since you did not explicitly document that a separate module is needed, I would prefer that)

/**
 * @defgroup isr_pipe_read_timeout  Read timeouts with ISR pipe
 * @ingroup  isr_pipe
 * @brief  ISR -> userspace pipe with timeout

[cladmi]

Ok I do the second one.

[cladmi]

I aligned the arguments to column 17 to match the other ones.
I also updated the C file to match the isr_pipe_read_timeout.

[cladmi]

I forced push to update the commit message then added the other one after.

[miri64]

ACK. Rendered doc also looks good:

[miri64]

Please squash

[cladmi]

Squashed, now waiting for the CI queue.

[miri64]

Apart from some label issues this is what murdock complains about. Please squash immediately

[cladmi]

I indeed missed that the module is called "isrpipe" and the group "isr_pipe" which I applied to the new group name.
Fixed and squashed.

[miri64]

I indeed missed that the module is called "isrpipe" and the group "isr_pipe" which I applied to the new group name.

we should fix the group naming actually, but not in this PR...

[cladmi]

Thanks for the review.