cpu/esp32: additional _ removed from __uart_* in static symbols#11272
Closed
gschorcht wants to merge 5 commits intoRIOT-OS:masterfrom
Closed
cpu/esp32: additional _ removed from __uart_* in static symbols#11272gschorcht wants to merge 5 commits intoRIOT-OS:masterfrom
gschorcht wants to merge 5 commits intoRIOT-OS:masterfrom
Conversation
An additional _ for static symbols has been added by mistake and should be removed. This will make future merging with the reimplementation of ESP8266 easier.
For consistency reasons, internal function _uart_config was moved to the section of internal functions.
For consistency reasons, external functions were moved to the section of external functions.
The interrupt handler is only used internally and declared to be static.
Function uart_set_baudrate which is only used internally was made static and renamed to _uart_set_baudrate to indicate that it is an internal function. Furthermore, an additional waiting for flushed TX FIFO added. The reconfiguration is now handled as critical section.
Contributor
Author
|
Closed by intention since the PR contains more cleanups than just renaming. Reopened with a new branch as PR #11276. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR removes the additional _ for static symbols that has been added by mistake. This will make future merging with the reimplementation of ESP8266 easier.
Testing procedure
Successful compilation of application
tests/uartshould be enough.If it more testing is required, compile and flash the
tests/uartapplication for a board that definesUART_DEV(1), e.g.,esp32-wroom-32:Connect GPIO9 and GPIO10 and execute the following test in terminal program
You should be able to observe the following output:
Issues/PRs references