boards/esp32: changes the approach for configurations of PWM channels in board definitions#11292
Merged
leandrolanzieri merged 2 commits intoRIOT-OS:masterfrom May 13, 2019
Merged
Conversation
gschorcht
added
Type: cleanup
This was referenced Mar 27, 2019
boards/esp32: changes the approach for configurations of UART interfaces in board definitions
#11294
Merged
Merged
Merged
leandrolanzieri
approved these changes
Mar 29, 2019
Contributor
leandrolanzieri
left a comment
leandrolanzieri
left a comment
There was a problem hiding this comment.
Looks good. Tested on esp32-wroom-32 and still works as intended. ACK
leandrolanzieri
added
Reviewed: 1-fundamentals
gschorcht
force-pushed
the
cpu/esp32/periph/conf/pwm
branch
from
7e56842 to
f5adc45
Compare
gschorcht
added
CI: ready for build
PWM channels are now configured using static array in header files instead of static variables in implementation.
PWM channels are now configured using static array in header files instead of static variables in implementation.
gschorcht
force-pushed
the
cpu/esp32/periph/conf/pwm
branch
from
f5adc45 to
bd354dd
Compare
MrKevinWeiss
added
CI: ready for build
Contributor
Author
|
@leandrolanzieri Can we merge this PR and PR #11293 to keep board definition approach consistent for all peripherals of ESP2 boards? |
leandrolanzieri
approved these changes
May 13, 2019
Contributor
leandrolanzieri
left a comment
leandrolanzieri
left a comment
There was a problem hiding this comment.
Retested, looks good. ACK.
Contributor
Author
|
Thanks for testing again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR changes the approach of peripheral configurations for PWM channels in board definitions to the usual RIOT approach. With these changes, peripheral configurations use static const arrays in the
boards/esp32*/periph_conf.hfiles and define the*_NUMOFmacros using the size of these static array.The static configuration arrays contain only definitions that can be changed by the board definition or the application. They do not contain any MCU implementation detail. The board definitions use preprocessor defines as before to fill these static configuration arrays. This makes it possible to override all configurations either with the make command or application specific configuration files.
Please note that commit 8b48dfd is in also in related PRs to get each PR compilable separately.
Testing procedure
Compilation and test with the most common ESP32 board should be executed
Issues/PRs references
PRs #11289 #11290 #11291 #11292 #11293 #11294 are releated and should be merged together.
Depends on PR #11289