Skip to content

minmea: bump version to current master#11579

Merged
maribu merged 3 commits intoRIOT-OS:masterfrom
miri64:minmea/enh/version-bump-2018
May 25, 2019
Merged

minmea: bump version to current master#11579
maribu merged 3 commits intoRIOT-OS:masterfrom
miri64:minmea/enh/version-bump-2018

Conversation

@miri64
Copy link
Member

@miri64 miri64 commented May 24, 2019

Contribution description

While reviewing #11227, I noticed, that the problem for ATmega platforms with the minmea package is easily fixable. And indeed it was fixed upstream. In addition to the fix and the removal of the blacklisting of the ATmega platforms for the test application, I also adapted the test application to use fmt so one also gets a sensible output with it for smaller platforms and newlib-nano.

Testing procedure

export BOARD="<your favorite>"
make -C tests/pkg_minmea flash
make -C tests/pkg_minmea test

I tested on samr21-xpro, native, arduino-mega2560, and arduino-leonardo.

Issues/PRs references

None

miri64 added 3 commits May 24, 2019 18:58
@miri64
tests/pkg_minmea: port to fmt
5522f3d 
With `newlib-nano` and other smaller `libc`s the output of floats does
not work with `printf()`. Since minmea uses floating point operations
I used `fmt` instead.
@miri64
minmea: bump version to current master
6273b30 
$ git log --oneline dbf51f03c5058746b4c4b3d6fdcd3d0357c5da36..HEAD
ae4dd94 Merge pull request #38 from noahp/noahp/check-url
b1371aa 🔗 update Check link
65bf740 Merge pull request #35 from gdpinchina/master
61c6ef7 fix test for gga
4514f6d fix test for gga
113221d fix test for gga
35b00bc fix test in gga
9fcd245 remove indent
59c3e0a fix gga char alignment problem in test.c
79b964a modefy initialization for dgps_age
c4a5a01 modify dgps_age type
c01cbcf modify dgps_age type
cd27e72 Merge pull request #29 from swilson/master
4d97109 Fix compiler warnings.
0456bbb Define timegm
04f1141 Add TI-RTOS compat header
8e4fc4e README.md: formatting fixes
0b02771 minmea.h: add Windows compatibility layer
ded4faf Merge pull request #25 from asund/master
f50449e Fixup whitespace
80af9b4 * Arrange year interpretation in order of likeliness * Add unit tests
ef8bca7 clarity of century use in struct tm
486da2b Small fixes to minmea_gettime * Handle four digit years provided by ZDA in minmea_gettime * Assume GPS epoch to allow dates prior 2000 to be parsed
@miri64
tests/pkg_minmea: remove blacklisting of ATmega-based boards
b251f96 
The reason for the blacklisting was fixed in the current version of
minmea.
@miri64 miri64 added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR labels May 24, 2019
@miri64 miri64 added this to the Release 2019.07 milestone May 24, 2019
@miri64 miri64 requested review from kaspar030 and maribu May 24, 2019 17:14
@miri64 miri64 marked this pull request as ready for review May 24, 2019 17:14
@maribu maribu added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines labels May 24, 2019
maribu
maribu approved these changes May 25, 2019
View reviewed changes
Copy link
Member

@maribu maribu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully on the bluepill using tests/pkg_minmea.

@maribu maribu added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels May 25, 2019
@maribu maribu merged commit 483feb7 into RIOT-OS:master May 25, 2019
@miri64 miri64 deleted the minmea/enh/version-bump-2018 branch May 25, 2019 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maribu maribu maribu approved these changes

@kaspar030 kaspar030 Awaiting requested review from kaspar030

Assignees

No one assigned

Labels

Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Milestone

Release 2019.07

Development

Successfully merging this pull request may close these issues.

2 participants

@miri64 @maribu