makefiles/pyocd.inc.mk use FLASHFILE#11696
Merged
MrKevinWeiss merged 2 commits intoRIOT-OS:masterfrom Jun 17, 2019
Merged
Conversation
OFLAGS is set by the `.bin` and `.hex` rules no need to define it anymore.
Update to use FLASHFILE as file to be flashed on the board.
MrKevinWeiss
approved these changes
Jun 14, 2019
Contributor
MrKevinWeiss
left a comment
There was a problem hiding this comment.
Seems simple, I tested with the nrf51dk and it seems to work. ACK.
Contributor
49 tasks
Contributor
Author
|
Thank you for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Update to use FLASHFILE as file to be flashed on the board.
This also removes
OFLAGSthat is set byMakefile.includein the.binand.hexrules.Testing procedure
You can flash on a board using
pyocdTesting without a board
The output of the FFLAGS is the same on master and this PR with the default and
pyocdprogrammer.for board in ${PYOCD_BOARDS}; do echo ${board}; BOARD=${board} make --no-print-directory -C examples/hello-world/ FLASHER=true flash-only; PROGRAMMER=pyocd BOARD=${board} make --no-print-directory -C examples/hello-world/ FLASHER=true flash-only; doneAnd the value can be changed from environment variable:
for board in ${PYOCD_BOARDS}; do echo ${board}; FLASHFILE=lala PROGRAMMER=pyocd BOARD=${board} make --no-print-directory -C examples/hello-world/ FLASHER=true flash-only; doneIssues/PRs references
Part of #8838