boards/pic32-xx: set FLASHFILE to HEXFILE#11699
Merged
MrKevinWeiss merged 1 commit intoRIOT-OS:masterfrom Jun 24, 2019
Merged
Conversation
The boards are using HEXFILE for flashing even if there is no FLASHER for the moment.
49 tasks
MrKevinWeiss
approved these changes
Jun 24, 2019
Contributor
MrKevinWeiss
left a comment
There was a problem hiding this comment.
It seems OK. Since there is no flash I cannot test on a board. If a flasher is added we should ensure it used FLASHFILE insead of the HEXFILE variable I suppose.
ACK!
Contributor
Author
|
Thank you for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
The boards are using HEXFILE for flashing even if there is no
FLASHER for the moment.
Testing procedure
The board do not have any flasher yet.
But in #9259 the flasher was added for
pic32-wifireandpic32progrequires theHEXFILE.Testing without board
The
hexfileis used as flashfile and it can be overwritten from the environment.Issues/PRs references
.hexand.binfile and add FLASHFILE variable #8838