Skip to content

boards/pic32-xx: set FLASHFILE to HEXFILE#11699

Merged
MrKevinWeiss merged 1 commit intoRIOT-OS:masterfrom
cladmi:pr/pic32/flashfile
Jun 24, 2019
Merged

boards/pic32-xx: set FLASHFILE to HEXFILE#11699
MrKevinWeiss merged 1 commit intoRIOT-OS:masterfrom
cladmi:pr/pic32/flashfile

Conversation

@cladmi
Copy link
Contributor

@cladmi cladmi commented Jun 14, 2019

Contribution description

The boards are using HEXFILE for flashing even if there is no
FLASHER for the moment.

Testing procedure

The board do not have any flasher yet.
But in #9259 the flasher was added for pic32-wifire and pic32prog requires the HEXFILE.

Testing without board

The hexfile is used as flashfile and it can be overwritten from the environment.

BOARD=pic32-wifire make --no-print-directory -C examples/hello-world/ info-debug-variable-FLASHFILE
/home/harter/work/git/RIOT/examples/hello-world/bin/pic32-wifire/hello-world.hex
BOARD=pic32-clicker make --no-print-directory -C examples/hello-world/ info-debug-variable-FLASHFILE
/home/harter/work/git/RIOT/examples/hello-world/bin/pic32-clicker/hello-world.hex

FLASHFILE=lala BOARD=pic32-wifire make --no-print-directory -C examples/hello-world/ info-debug-variable-FLASHFILE
lala
FLASHFILE=lala BOARD=pic32-clicker make --no-print-directory -C examples/hello-world/ info-debug-variable-FLASHFILE
lala

Issues/PRs references

The boards are using HEXFILE for flashing even if there is no
FLASHER for the moment.
@cladmi cladmi added Area: build system Area: Build system Area: tools Area: Supplementary tools Platform: MIPS Platform: This PR/issue effects MIPS-based platforms labels Jun 14, 2019
@cladmi cladmi added this to the Release 2019.07 milestone Jun 14, 2019
@cladmi cladmi requested review from MrKevinWeiss and neiljay June 14, 2019 13:15
@MrKevinWeiss MrKevinWeiss added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jun 24, 2019
Copy link
Contributor

@MrKevinWeiss MrKevinWeiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems OK. Since there is no flash I cannot test on a board. If a flasher is added we should ensure it used FLASHFILE insead of the HEXFILE variable I suppose.

ACK!

@MrKevinWeiss MrKevinWeiss merged commit cc13558 into RIOT-OS:master Jun 24, 2019
@cladmi
Copy link
Contributor Author

cladmi commented Jun 25, 2019

Thank you for the review.

@cladmi cladmi deleted the pr/pic32/flashfile branch June 25, 2019 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: build system Area: Build system Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: MIPS Platform: This PR/issue effects MIPS-based platforms

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants