makefiles/bossa.inc.mk: use FLASHFILE#11700
Merged
leandrolanzieri merged 1 commit intoRIOT-OS:masterfrom Jun 17, 2019
Merged
Conversation
Update to use FLASHFILE as file to be flashed on the board.
Contributor
Author
|
I forgot to put |
49 tasks
leandrolanzieri
approved these changes
Jun 17, 2019
Contributor
leandrolanzieri
left a comment
There was a problem hiding this comment.
Looks good. I also tested this with sensebox, soda-sara-aff and feather-m0, the flashfile is successfully overwritten from the environment. ACK.
Contributor
Author
|
Thank you for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Update to use FLASHFILE as file to be flashed on the board.
Testing procedure
You can flash on a board using bossa.
Testing without a board
The flash command is still the same with this PR and with master
Here
PREFLASHERmust be updated otherwise it tries to use a board that is not there.for board in ${BOSSA_BOARDS}; do echo ${board}; PROGRAMMER=bossa FLASHFILE=lala BOARD=${board} make --no-print-directory -C examples/hello-world/ FLASHER=true PREFLASHER=true flash-only; doneAnd the file to flash can be overwritten from environment
for board in ${BOSSA_BOARDS}; do echo ${board}; PROGRAMMER=bossa FLASHFILE=lala BOARD=${board} make --no-print-directory -C examples/hello-world/ FLASHER=true PREFLASHER=true flash-only; doneIssues/PRs references
Part of #8838