boards/mspdebug: use FLASHFILE for boards using mspdebug#11708
Merged
MrKevinWeiss merged 1 commit intoRIOT-OS:masterfrom Jun 25, 2019
Merged
boards/mspdebug: use FLASHFILE for boards using mspdebug#11708MrKevinWeiss merged 1 commit intoRIOT-OS:masterfrom
MrKevinWeiss merged 1 commit intoRIOT-OS:masterfrom
Conversation
49 tasks
Contributor
Author
|
Added test for the squash commit. |
Contributor
|
I think it looks good. I cannot test on a board but the tests provided along with the simplicity of the change makes it seem OK to me. Please squash. |
5cb9048 to
60bf01c
Compare
Update to use FLASHFILE as file to be flashed on the board. IOTLAB_FLASHFILE also uses 'FLASHFILE' (and not the default 'ELFFILE').
60bf01c to
6538d71
Compare
Contributor
Author
|
Squashed and rebased. |
Contributor
Author
|
Thank you for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Update to use FLASHFILE as file to be flashed on the board.
Testing procedure
You can flash on a board using
mspdebug.Testing without a board
The output of the FFLAGS is the same on master and this PR.
for board in ${MSPDEBUG_BOARDS}; do echo ${board}; BOARD=${board} make --no-print-directory -C examples/hello-world/ FLASHER=true flash-only; doneAnd the value can be changed from environment variable:
for board in ${MSPDEBUG_BOARDS}; do echo ${board}; FLASHFILE=toto BOARD=${board} make --no-print-directory -C examples/hello-world/ FLASHER=true flash-only; doneIOTLAB_NODE update
The value for
IOTLAB_NODEis correctly overwritten to the.hexfile as it was in master.Issues/PRs references
Part of #8838