boards/dfu-util: use FLASHFILE for boards using dfu-util#11709
Merged
MrKevinWeiss merged 2 commits intoRIOT-OS:masterfrom Jun 24, 2019
Merged
boards/dfu-util: use FLASHFILE for boards using dfu-util#11709MrKevinWeiss merged 2 commits intoRIOT-OS:masterfrom
MrKevinWeiss merged 2 commits intoRIOT-OS:masterfrom
Conversation
Update to use FLASHFILE as file to be flashed on the board.
Update to use FLASHFILE as file to be flashed on the board.
49 tasks
MrKevinWeiss
approved these changes
Jun 24, 2019
Contributor
MrKevinWeiss
left a comment
There was a problem hiding this comment.
ACK. Tested only on the bluepill with dfu utils. I was able to flash tests/shell with
BOARD=bluepill FLASHFILE=/home/kevinweiss/WorkingDirectory/RIOT/tests/shell/bin/bluepill/tests_shell.bin PROGRAMMER=dfu-util make -C tests/leds/ flash-only
Contributor
Author
|
Thank you for the review and doing actual board testing :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Update to use FLASHFILE as file to be flashed on the board.
Testing procedure
Flash on a board using
dfu-utilTesting without a board
The output of the
FFLAGShas the same file as in master.It is a bit different as I removed the
"around the file name as we do not do it for any other boards.for board in ${DFU_BOARDS}; do echo ${board}; PROGRAMMER=dfu-util BOARD=${board} make --no-print-directory -C examples/hello-world/ FLASHER=true flash-only; doneOnly diff is the
"that were removedwdiff output_master output_pr blackpill true -d 1eaf:0003 -a 2 -D [-"/home/harter/work/git/RIOT/examples/hello-world/bin/blackpill/hello-world.bin"-] {+/home/harter/work/git/RIOT/examples/hello-world/bin/blackpill/hello-world.bin+} bluepill true -d 1eaf:0003 -a 2 -D [-"/home/harter/work/git/RIOT/examples/hello-world/bin/bluepill/hello-world.bin"-] {+/home/harter/work/git/RIOT/examples/hello-world/bin/bluepill/hello-world.bin+} nz32-sc151 true -d 0483:df11 -a 0 -s 0x08000000:leave -D [-"/home/harter/work/git/RIOT/examples/hello-world/bin/nz32-sc151/hello-world.bin"-] {+/home/harter/work/git/RIOT/examples/hello-world/bin/nz32-sc151/hello-world.bin+} pyboard true -D /home/harter/work/git/RIOT/examples/hello-world/bin/pyboard/hello-world.bin --reset --alt 0 -s 0x8000000 spark-core true -d 1d50:607f -a 0 -s 0x08005000:leave -D [-"/home/harter/work/git/RIOT/examples/hello-world/bin/spark-core/hello-world.bin"-] {+/home/harter/work/git/RIOT/examples/hello-world/bin/spark-core/hello-world.bin+}The value can be changed from environment variable:
for board in ${DFU_BOARDS}; do echo ${board}; PROGRAMMER=dfu-util FLASHFILE=beer BOARD=${board} make --no-print-directory -C examples/hello-world/ FLASHER=true flash-only; doneIssues/PRs references
Part of #8838