makefiles/murdock.inc.mk: remove flashfile hack#11755
Merged
cladmi merged 1 commit intoRIOT-OS:masterfrom Jun 28, 2019
Merged
Conversation
Setting FLASHFILE is now done for all boards requiring it.
49 tasks
Contributor
Author
|
CI is green. |
Contributor
Author
|
Thanks for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Setting FLASHFILE is now done for all boards requiring it.
Testing procedure
Both on the current master and this PR,
FLASHFILEhas the same value.for board in $(make info-boards); do echo ${board}; PORT=/dev/null ESP8266_NEWLIB_DIR=/tmp ESP32_SDK_DIR=/tmp ESP8266_SDK_DIR=/tmp BOARD=${board} make --no-print-directory -C examples/hello-world/ info-debug-variable-FLASHFILE; done | sed "s|${PWD}/||"You can note that
nativehas noFLASHFILE, but it did not have a value inmastereither.(addressed in #11752)
Issues/PRs references
.hexand.binfile and add FLASHFILE variable Makefiles: add support to generate both.hexand.binfile and add FLASHFILE variable #8838