Makefile.include: do not build HEXFILE by default anymore#11757
Merged
MrKevinWeiss merged 1 commit intoRIOT-OS:masterfrom Jul 16, 2019
Merged
Conversation
49 tasks
Contributor
Author
|
The build indeed failed only because of |
Contributor
we should move those checks to murdock's post-build scripts, so the tags get evaluated at the end of a build. |
Contributor
Author
In that case, it was correct as it was waiting for the other PR. One nice thing would be to say "only static-tests failed" as status in github. |
All boards must now use FLASHFILE
ace3a17 to
37e72e1
Compare
Contributor
Author
|
Rebase now that |
MrKevinWeiss
approved these changes
Jul 16, 2019
Contributor
MrKevinWeiss
left a comment
There was a problem hiding this comment.
Seems good now and murdock passes. ACK!
Contributor
Author
|
Thanks for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
All boards must now use FLASHFILE
Testing procedure
Building and testing in CI will work as expected.
I will only fail due to the
waiting for other PR.Solves the issue for
mips-maltaThis change has been dropped as
board/mips-maltahas been removed.Issues/PRs references
Waiting for #11752 to be accurate with the documentation. But there is not build dependency.
Part of introducing FLASHFILE #8838