Skip to content

Makefile.include: do not build HEXFILE by default anymore#11757

Merged
MrKevinWeiss merged 1 commit intoRIOT-OS:masterfrom
cladmi:pr/make/do_not_build_hexfile_by_default
Jul 16, 2019
Merged

Makefile.include: do not build HEXFILE by default anymore#11757
MrKevinWeiss merged 1 commit intoRIOT-OS:masterfrom
cladmi:pr/make/do_not_build_hexfile_by_default

Conversation

@cladmi
Copy link
Contributor

@cladmi cladmi commented Jun 27, 2019

Contribution description

All boards must now use FLASHFILE

Testing procedure

Building and testing in CI will work as expected.
I will only fail due to the waiting for other PR.

Solves the issue for mips-malta

This change has been dropped as board/mips-malta has been removed.

boards/mips-malta: do not overwrite HEXFILE

Building the .hex file is failing on mips-malta.
Now that HEXFILE is not always built, it is not necessary to overwrite
it with BINFILE.

When only removing the HEXFILE = $(BINFILE) you get the following error.

DOCKER="sudo docker" BUILD_IN_DOCKER=1 BOARD=mips-malta make -C examples/hello-world/
...

BFD: /data/riotbuild/riotbase/examples/hello-world/bin/mips-malta/hello-world.hex: address 0xffffffff80000000 out of range for Intel Hex file
/opt/mips-mti-elf/2016.05-03/bin/mips-mti-elf-objcopy:/data/riotbuild/riotbase/examples/hello-world/bin/mips-malta/hello-world.hex: Bad value
/data/riotbuild/riotbase/Makefile.include:487: recipe for target '/data/riotbuild/riotbase/examples/hello-world/bin/mips-malta/hello-world.hex' failed
make: *** [/data/riotbuild/riotbase/examples/hello-world/bin/mips-malta/hello-world.hex] Error 1
/home/harter/work/git/RIOT/makefiles/docker.inc.mk:266: recipe for target '..in-docker-container' failed

So the change in Makefile.include fixes the workaround described in 78fdc49

Issues/PRs references

Waiting for #11752 to be accurate with the documentation. But there is not build dependency.

Part of introducing FLASHFILE #8838

@cladmi cladmi added Area: build system Area: Build system Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation State: waiting for other PR State: The PR requires another PR to be merged first CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR CI: disable test cache If set, CI will always run all tests regardless of whether they have been run successfully before labels Jun 27, 2019
@cladmi cladmi added this to the Release 2019.07 milestone Jun 27, 2019
@cladmi cladmi requested a review from MrKevinWeiss June 27, 2019 13:52
@cladmi cladmi removed State: waiting for other PR State: The PR requires another PR to be merged first CI: disable test cache If set, CI will always run all tests regardless of whether they have been run successfully before CI: run tests If set, CI server will run tests on hardware for the labeled PR labels Jun 28, 2019
@cladmi
Copy link
Contributor Author

cladmi commented Jun 28, 2019

The build indeed failed only because of

Running './dist/tools/pr_check/pr_check.sh master' x
Command output:

	Pull request is waiting for another pull request according to its labels set on GitHub

@kaspar030
Copy link
Contributor

The build indeed failed only because of

we should move those checks to murdock's post-build scripts, so the tags get evaluated at the end of a build.

@cladmi
Copy link
Contributor Author

cladmi commented Jun 28, 2019

The build indeed failed only because of

we should move those checks to murdock's post-build scripts, so the tags get evaluated at the end of a build.

In that case, it was correct as it was waiting for the other PR.

One nice thing would be to say "only static-tests failed" as status in github.

@cladmi cladmi force-pushed the pr/make/do_not_build_hexfile_by_default branch from ace3a17 to 37e72e1 Compare July 15, 2019 17:16
@cladmi
Copy link
Contributor Author

cladmi commented Jul 15, 2019

Rebase now that mips-malta has been dropped.

Copy link
Contributor

@MrKevinWeiss MrKevinWeiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good now and murdock passes. ACK!

@MrKevinWeiss MrKevinWeiss merged commit 1ad3c78 into RIOT-OS:master Jul 16, 2019
@cladmi
Copy link
Contributor Author

cladmi commented Jul 16, 2019

Thanks for the review.

@cladmi cladmi deleted the pr/make/do_not_build_hexfile_by_default branch July 16, 2019 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: build system Area: Build system CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants