dist/tools/ethos: deduplicate setup_network.sh, start_network.sh

[kaspar030]

Contribution description

#11816 introduced setup_network.sh, introducing some duplication with start_network.sh.
This PR aims to remove the duplications.

Testing procedure

• ensure examples/suit_update (sys/suit: initial support for SUIT firmware updates #11818) still works (using setup_network.sh)
• ensure users of start_network.sh still work

Issues/PRs references

[fjmolinas]

I tested this still works on #11818, tests is passing as before.

[fjmolinas]

I tested start_network.sh by running the test in #11818 using wireless nodes. The BR was an iotlab-m3.

I also tested gnrc_networking on a samr21-xpro with the same BR and I was able to ping the samr21-xpro from my local host.

If you agree with my changes then squash directly.

[fjmolinas]

This fails to kill all the decedent processes, I would suggest this change:

diff --git a/dist/tools/ethos/start_network.sh b/dist/tools/ethos/start_network.sh
index 4f832a258..a457735e0 100755
--- a/dist/tools/ethos/start_network.sh
+++ b/dist/tools/ethos/start_network.sh
@@ -3,13 +3,13 @@
 ETHOS_DIR="$(dirname $(readlink -f $0))"
 
 cleanup() {
-    [ -n "${SETUP_NETWORK_PID}" ] && kill -TERM ${SETUP_NETWORK_PID}
     trap "" INT QUIT TERM EXIT
+    [ -n "${SETUP_NETWORK_GPID}" ] && kill -TERM -$SETUP_NETWORK_GPID
 }
 
 setup_network() {
     ${ETHOS_DIR}/setup_network.sh $1 $2 &
-    SETUP_NETWORK_PID=$!
+    SETUP_NETWORK_GPID=$(ps -o pgid= $! | grep -o '[0-9]*')
 }
 
 PORT=$1

[fjmolinas]

ping @kaspar030

[fjmolinas]

ping @kaspar030

[fjmolinas]

ping @kaspar030!

[fjmolinas]

this should be a low hanging fruit..

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions.

[miri64]

Ping @kaspar030

[kaspar030]

this should be a low hanging fruit..

honestly I'm lost on this one, rebasing is messy due to the DHCPv6 additions. Does one of you want to take over (or re-do it)?

[miri64]

this should be a low hanging fruit..

honestly I'm lost on this one, rebasing is messy due to the DHCPv6 additions. Does one of you want to take over (or re-do it)?

Was planning on that anyway (also to integrate with tapsetup) some time. Let's close this as memo archived for now then?