Skip to content

cpu/mips32r2_generic: remove cpu.#11846

Merged
jcarrano merged 2 commits intoRIOT-OS:masterfrom
jcarrano:mips32r2_generic-is-gone
Jul 22, 2019
Merged

cpu/mips32r2_generic: remove cpu.#11846
jcarrano merged 2 commits intoRIOT-OS:masterfrom
jcarrano:mips32r2_generic-is-gone

Conversation

@jcarrano
Copy link
Contributor

Contribution description

The mips32r2_generic CPU was only used by the mips-malta board which has been removed. The reasons for this removal are the same as for the board:

  • No hardware to test.
  • The board that used this CPU is not available off the shelf.
  • No UART input.
  • No integrated flasher (one needs to use a separate Windows tool)

Testing procedure

git grep mips32r2_generic shows no traces of the board left. Successful compilation of all the other boards should verify that nothing was broken.

Issues/PRs references

For more information and discussion around MIPS, see issues:

jcarrano added 2 commits July 16, 2019 11:09
The `mips32r2_generic` CPU was only used by the `mips-malta` board which has
been removed. The reasons for this removal are the same as for the board:

- No hardware to test.
- The board that used this CPU is not available off the shelf.
- No UART input.
- No integrated flasher (one needs to use a separate Windows tool)

For more information and discussion around MIPS, see issues:

- RIOT-OS#11831 (Removal of mips-malta)
- RIOT-OS#11788 (General MIPS removal)
Note: git show @cladmi as the author of the files, but he just did a
refactoring, the real author was @neiljay.
@jcarrano jcarrano added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: MIPS Platform: This PR/issue effects MIPS-based platforms Area: cpu Area: CPU/MCU ports labels Jul 16, 2019
@jcarrano jcarrano changed the title Mips32r2 generic is gone cpu/mips32r2_generic: remove cpu. Jul 16, 2019
@jcarrano
Copy link
Contributor Author

D'oh! sorry for the PR title, github set it automatically from the branch name. It's fixed now.

Copy link
Member

@smlng smlng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

no board, no cpu needed

Sensible cleanup, well documented.

@jcarrano jcarrano merged commit 7dd00b7 into RIOT-OS:master Jul 22, 2019
@kb2ma kb2ma added this to the Release 2019.10 milestone Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: MIPS Platform: This PR/issue effects MIPS-based platforms Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants