Skip to content

boards/hamilton: remove OFLAGS '-O binary'#11849

Merged
jcarrano merged 1 commit intoRIOT-OS:masterfrom
cladmi:pr/hamilton/oflags
Jul 18, 2019
Merged

boards/hamilton: remove OFLAGS '-O binary'#11849
jcarrano merged 1 commit intoRIOT-OS:masterfrom
cladmi:pr/hamilton/oflags

Conversation

@cladmi
Copy link
Contributor

@cladmi cladmi commented Jul 16, 2019

Contribution description

The 'binary' output format is now given by default to .bin files creation

This was changed before hamilton board integration but not updated in the PR.

Testing procedure

The -O binary flag is only once in the objcopy output and compilation gives the same .bin file.

objcopy

RIOT_CI_BUILD=1 BOARD=hamilton QUIET=0 make --no-print-directory -C examples/hello-world/ | grep objcopy
/opt/gcc-arm-none-eabi-7-2018-q2-update/bin/arm-none-eabi-objcopy --gap-fill 0xff -Obinary /data/riotbuild/riotbase/examples/hello-world/bin/hamilton/hello-world.elf /data/riotbuild/riotbase/examples/hello-world/bin/hamilton/hello-world.bin

In master it had two times -O binary.

BUILD_IN_DOCKER=1 RIOT_CI_BUILD=1 BOARD=hamilton make --no-print-directory -C examples/hello-world/ QUIET=0 | grep objcopy
/opt/gcc-arm-none-eabi-7-2018-q2-update/bin/arm-none-eabi-objcopy -O binary --gap-fill 0xff -Obinary /data/riotbuild/riotbase/examples/hello-world/bin/hamilton/hello-world.elf /data/riotbuild/riotbase/examples/hello-world/bin/hamilton/hello-world.bin

binary output

The binary is the same for both

sha256sum examples/hello-world/bin/hamilton/hello-world.bin
a8283b86d7e4a87bcaebde1447a3f419d968317044d2880aeb4b2b2a9d66fdec  examples/hello-world/bin/hamilton/hello-world.bin

Issues/PRs references

Part of the #8838 changes

The 'binary' output format is now given by default to .bin files creation
@jcarrano jcarrano added Area: boards Area: Board ports Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jul 17, 2019
Copy link
Contributor

@jcarrano jcarrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works.

@jcarrano jcarrano merged commit 3c7efb2 into RIOT-OS:master Jul 18, 2019
@cladmi
Copy link
Contributor Author

cladmi commented Jul 18, 2019

Thank you for the review.

@cladmi cladmi deleted the pr/hamilton/oflags branch July 18, 2019 10:09
@kb2ma kb2ma added this to the Release 2019.10 milestone Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: boards Area: Board ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants