Skip to content

sys/auto_init: Updated sht1x auto_init#11872

Closed
maribu wants to merge 3 commits intoRIOT-OS:masterfrom
maribu:sht1x_auto_init
Closed

sys/auto_init: Updated sht1x auto_init#11872
maribu wants to merge 3 commits intoRIOT-OS:masterfrom
maribu:sht1x_auto_init

Conversation

@maribu
Copy link
Member

@maribu maribu commented Jul 19, 2019

Contribution description

This PR adapts the SHT1X auto init code to match the new API suggested in #11871.

Testing procedure

  • Grab an MSB-A2 and check if the SHT1X driver is properly auto initialized e.g. in /examples/saul.
  • Check if auto-initialization can be properly disabled

Issues/PRs references

@maribu maribu added State: waiting for other PR State: The PR requires another PR to be merged first Area: SAUL Area: Sensor/Actuator Uber Layer Area: sys Area: System labels Jul 19, 2019
This was referenced Jul 19, 2019
Closed
Open
@ghost ghost requested a review from kaspar030 July 23, 2019 20:24
@maribu
Copy link
Member Author

maribu commented Aug 21, 2019

Rebased on top of #11871

haukepetersen
haukepetersen requested changes Oct 17, 2019
View reviewed changes
Copy link
Contributor

@haukepetersen haukepetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, I think this could be a way to move the device descriptor allocation into the context of the drivers themselves. But lets first elaborate a little more on #11871 before looking at how to put this into the driver code.

@maribu maribu force-pushed the sht1x_auto_init branch 2 times, most recently from 75fd510 to bd19cb0 Compare February 9, 2020 21:37
@fjmolinas fjmolinas self-requested a review March 18, 2020 14:04
@miri64
Copy link
Member

miri64 commented Jun 25, 2020 •
edited
Loading

@haukepetersen are your comments addressed? @maribu please rebase. Sorry, missed the waiting on other PR label on this one

@maribu
Copy link
Member Author

maribu commented Aug 25, 2020

Rebased on top of #11871

@stale
Copy link

stale bot commented Mar 19, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions.

@stale stale bot added the State: stale State: The issue / PR has no activity for >185 days label Mar 19, 2021
@fjmolinas
Copy link
Contributor

fjmolinas commented Mar 20, 2021

It would be awesome to see this go forward.

@stale stale bot removed the State: stale State: The issue / PR has no activity for >185 days label Mar 20, 2021
@maribu maribu force-pushed the sht1x_auto_init branch from cb21b2b to 37ba150 Compare April 1, 2021 07:47
@maribu
Copy link
Member Author

maribu commented Apr 1, 2021

Rebased to solve merge conflicts. Also changed indent in switch to match coding convention.

@fjmolinas
Copy link
Contributor

fjmolinas commented Apr 1, 2021

@maribu 37ba150 seems to be mixing a lot of changes and the commit message does not represent those completely does it?

@maribu
Copy link
Member Author

maribu commented Apr 1, 2021

I split the cleanup of sys/Makefile.dep already out: #16268

I will do the same for the style fixes.

maribu added 3 commits April 1, 2021 15:33
@maribu
sys/auto_init: Add modules for sensors & actuators
53d84cf 
- Added module auto_init_actuators_sensors to auto-initialize actuator
  and sensor drivers
    - Auto-initialization for actuator/sensor driver `foo` will be
      implemented in submodule `auto_init_actuators_sensors_foo`
    - SAUL registration is also performed by that hook, if
      `auto_init_saul` is used
- Pseudo-module `auto_init_sensors_actuators_default` is used to pull in
  sensor and actuator auto_init submodules for all drivers used
- Made `auto_init_saul` depend on `auto_init_sensors_actuators_default`
@maribu
makefiles: auto_init_sensors_actuators_default as default module
3c1ec3d 
By default, auto initialize all used sensor and actuator drivers.
@maribu
sys/auto_init: Adapted SHT1x auto_init
4f426f7 
- Moved auto initialization of the SHT1X driver to module
  auto_init_actuators_sensors
- Added sht1x_get_dev() helper to retrieve auto-initialized device
- Adapted shell commands of the SHT1X to depend on
  auto_init_actuators_sensors_sht1x and use sht1x_get_dev()
@maribu maribu force-pushed the sht1x_auto_init branch from 37ba150 to 4f426f7 Compare April 1, 2021 13:38
@MrKevinWeiss MrKevinWeiss added this to the Release 2021.07 milestone Jun 21, 2021
@MrKevinWeiss MrKevinWeiss removed this from the Release 2021.07 milestone Jul 15, 2021
@stale
Copy link

stale bot commented Mar 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions.

@stale stale bot added the State: stale State: The issue / PR has no activity for >185 days label Mar 2, 2022
@stale stale bot closed this Apr 17, 2022
@fjmolinas
Copy link
Contributor

fjmolinas commented Apr 19, 2022

We could still gets this if you want @maribu

@maribu
Copy link
Member Author

maribu commented Apr 19, 2022

I was aiming for a rewrite based on XFA :) So I keep this one here for reference and hopefully create a new try with XFA as new PR.

@maribu maribu deleted the sht1x_auto_init branch January 21, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haukepetersen haukepetersen haukepetersen requested changes

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner

@kaspar030 kaspar030 Awaiting requested review from kaspar030

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

Assignees

No one assigned

Labels

Area: SAUL Area: Sensor/Actuator Uber Layer Area: sys Area: System State: stale State: The issue / PR has no activity for >185 days State: waiting for other PR State: The PR requires another PR to be merged first

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@maribu @miri64 @fjmolinas @haukepetersen @MrKevinWeiss