sys/Makefile.include: check for newlib_nano instead of USE_NANO_SPECS [backport 2019.07]#11890
Closed
cladmi wants to merge 2 commits intoRIOT-OS:2019.07-branchfrom
Closed
Conversation
Check for the usage of `newlib_nano` module instead of the `USE_NANO_SPECS` variable. This allows also benefiting from the `printf_float` and `scanf_float` behaviour on `arm7` and `riscv` cpus. (cherry picked from commit 225b50c)
It was replaced by using directly the `newlib_nano` module. (cherry picked from commit 2d5ed4f)
3 tasks
miri64
added
the
CI: ready for build
Member
|
@MrKevinWeiss I think this should have been included into the release. How do we proceed? |
Contributor
|
I really don't think this warrants a new patch... I would be OK just updating the release notes. If it is really needed to get in the release I would maybe wait for a while just in case some other bugs are found then do a new release. Any objections? |
Contributor
|
Oh jeez I guess I just missed it, it was done before the release happened 😲 I really should have kept a closer eye and set the labels better. |
MrKevinWeiss
added
Process: release backport
Contributor
Author
|
It was listed in the Line 415 in e612d3d |
cladmi
deleted the
backport/2019.07/pr/newib/remove_use_nano_specs_variable
branch
MrKevinWeiss
removed
Process: release backport
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #11883
Contribution description
Check for the usage of
newlib_nanomodule instead of theUSE_NANO_SPECSvariable.This allows also benefiting from the
printf_floatandscanf_floatbehaviour on
arm7andriscvcpus.Testing procedure
Verify it is actually handled correctly on
arm7andriscvboards.Run the
tests/unittests tests-scanf_floatonarm7andriscvboards.Run other relevant tests:
Issues/PRs references
General fix for #11882
USE_NANO_SPECSwas added in #5094Not sure why it was not set with
newlib_nanoat the end.