cpu/saml1x: update periph status implementation in board doc.txt#11892
cpu/saml1x: update periph status implementation in board doc.txt#11892benpicco merged 2 commits intoRIOT-OS:masterfrom
Conversation
|
I just ran tests/periph_adc on a saml11-xpro which works somehow but I think something might be messed up in the peripheral driver implementation. In main.c we sample with 10 bit but the test prints values between ~ 96 ... 65520 for ~0...3.3V which shouldn't be possible at 10 bit right? @dylad any ideas? |
|
I'll take a closer look at it next week. |
I have one. I'll submit a PR soon so you can fully test it. |
|
@Einhornhool regarding this PR, do you want to wait for #11647 to be merge first so we can merge this one or you can remove hwrng support from the list and we can merge it right now. |
|
@dylad Thank you for working on this =) |
|
Yeah it's been merged in the meantime, no need to remove RNG support - it's been tested. However, there are open issues with the ADC implementation. @dylad any news on that? |
|
@PeterKietzmann #11972 should fixes your issue, I have limited access to my hardware because I'm moving so I cannot fully test it right now. |
|
ADC's are fine with #11972. @Einhornhool please adopt @benpicco's comment. We are ready to merge afterwards. |
|
@PeterKietzmann Thanks, will do. Guess I made a mistake there. |
|
I'd say you can squash right away. |
Co-Authored-By: benpicco <benpicco@googlemail.com>
4b9948e to
58955b3
Compare
|
@benpicco done |
benpicco
left a comment
There was a problem hiding this comment.
All comments addressed, so this is good to go!
Contribution description
Updated the implementation status of the boards saml10-xpro and saml11-xpro.
Before only support of low-level drivers GPIO, UART and Timer was documented.
Testing showed that I2C, SPI, RTT, RTC, RNG and ADC also work on both boards.
Testing procedure
I ran the following tests:
periph_i2c
periph_spi
periph_rtt
periph_rtc
periph_adc
rng