cpu/esp32: disable multiheap memory management#11942
Closed
gschorcht wants to merge 3 commits intoRIOT-OS:masterfrom
Closed
cpu/esp32: disable multiheap memory management#11942gschorcht wants to merge 3 commits intoRIOT-OS:masterfrom
gschorcht wants to merge 3 commits intoRIOT-OS:masterfrom
Conversation
Multiheap implementation of the SDK is only compiled when the esp_idf_heap module is enabled.
Due instabilities in memory management, multiheap handling is disabled with in current implementation. newlibc memory management is used instead. Since SPI RAM access requires mutliheap heandling capabilities, module esp_spi_ram is disabled for the moment. If it is tried to be used by the application, an error message is thrown during make.
gschorcht
added
Platform: ESP
yegorich
reviewed
Jul 31, 2019
cpu/esp32/Makefile.dep
Outdated
| ifneq (,$(filter esp_spi_ram,$(USEMODULE))) | ||
| USEMODULE += esp_idf_heap | ||
| # USEMODULE += esp_idf_heap | ||
| $(error Module esp_spi_ram can't be use with current implementation) |
Contributor
There was a problem hiding this comment.
s/use/used
s/current/the current
Contributor
Author
There was a problem hiding this comment.
yep, of course, it was just a typo.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR disables the multiheap memory management as a temporary workaround for issue #11941.
Testing procedure
Setup a ESP-NOW network of two ESP32 nodes. For that purpose compile and flash two nodes with:
After that, connect to the nodes with a terminal program and use some commands like
ifconfigandping6to check whether it works and wait for 1 hour or so. There should noCORRUPTmessage anymore.Issues/PRs references
Temporary workaround for #11941.