makefiles/info-global.inc.mk: bug: honor DEFAULT_MODULES#12011
Merged
jcarrano merged 1 commit intoRIOT-OS:masterfrom Aug 21, 2019
Merged
makefiles/info-global.inc.mk: bug: honor DEFAULT_MODULES#12011jcarrano merged 1 commit intoRIOT-OS:masterfrom
jcarrano merged 1 commit intoRIOT-OS:masterfrom
Conversation
5753905 to
081eb9c
Compare
Contributor
Author
|
Rebased due to conflict in |
jcarrano
approved these changes
Aug 20, 2019
Contributor
jcarrano
left a comment
There was a problem hiding this comment.
Looks good to me and restores the original, sensible behaviour of this variable.
Contributor
Author
|
This one is implemented on top of #12010 and the debug targets from #12004 Should I squash to remove the test commits ? I just noticed I did not provide the diff in the description. When running the same procedure as in #12014 And we can see that |
The parsing for info-boards-supported was completely ignoring default modules.
081eb9c to
4516905
Compare
Contributor
Author
|
Rebased and removed the debug target commit now that #12010 is in. |
Contributor
Author
|
Thank you for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
The parsing for info-boards-supported was completely ignoring default
modules.
Testing procedure
Review that both lines are done in
Makefile.include.Murdock should compile everything without error.
I will post a diff using dependencies resolution output when I have it.
When running the same procedure as in #12014
And comparing the difference of the aggregated
info-boards-supporteddebug output I get:And we can see that
USEMODULEnow has values from theDEFAULT_MODULE:Issues/PRs references
This is based on