makefiles/info-global.inc.mk: bug: handle FEATURES_CONFLICT value#12041
Merged
jcarrano merged 1 commit intoRIOT-OS:masterfrom Aug 21, 2019
Merged
Conversation
jcarrano
added
Area: build system
The value must be saved from the original value to allow restoring it. This has currently no impact on 'info-boards-supported' as it is currently ignored.
cladmi
force-pushed
the
pr/makefiles/info_global/features_conflict
branch
from
3ce4ea9 to
8c0120a
Compare
Contributor
Author
|
Rebased as #12010 was merged |
Contributor
Author
|
Thank you for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
The value must be saved from the original value to allow restoring it.
This has currently no impact on 'info-boards-supported' as it is
currently ignored.
Testing procedure
After applying this debug diff:
With this pull request the value is correctly restored and is consistent with the board
make --no-print-directory -C examples/hello-world/ info-boards-supported 2>&1 | sed "s|${PWD}/||"Where in master it kept accumulating the previous values
make --no-print-directory -C examples/hello-world/ info-boards-supported 2>&1 | sed "s|${PWD}/||"Issues/PRs references
Similar to "makefiles/info-global.inc.mk: bug: fix DISABLE_MODULE_GLOBAL value #12010"
It introduced false positive when debugging #11477