boards/nrf52: cleanup shared Makefile.deps#12114
Closed
haukepetersen wants to merge 4 commits intoRIOT-OS:masterfrom
Closed
boards/nrf52: cleanup shared Makefile.deps#12114haukepetersen wants to merge 4 commits intoRIOT-OS:masterfrom
haukepetersen wants to merge 4 commits intoRIOT-OS:masterfrom
Conversation
Contributor
Author
|
Just in case someone is wondering: for some reason, some of the effected boards were per default using the |
Contributor
|
Could this be considered as a duplicate of #11792 ? (I haven't look into the details). |
Contributor
Author
|
Just noticed: this PR also fixes all |
Contributor
Author
Contributor
Author
|
closing in favor of #11792 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
The
nrf52832and thenrf52840-based platforms have different default radio modes (nimble_netifandnrf802154, respectively). But the accordingMakefile.deps were a little messy, so this PR should improve on this...Testing procedure
For
gnrc_networking, verify that allnrf52840boards are now being build with the 802.15.4 support (nrf802154) and allnrf52832baords with IP-over-BLE support (nimble_netif). Also, all boards should flawlessly build withnrfmin.Issues/PRs references
none