boards/pic32-{clicker,wifire}: delete boards#12147
boards/pic32-{clicker,wifire}: delete boards#12147jcarrano wants to merge 1 commit intoRIOT-OS:masterfrom
Conversation
Note: in contrast to mips-malta, these boards are still available for purchase.
This means that if the issued listed below were to be fixed (and the boards
maintained by a person versed in the architecture) then adding them back
would be a valid possibility.
The pic32-clicker and pic32-wifire have severe issues affecting their usability,
maintainability and have no maintainer.
1. Usability
============
I doubt the current implementation of these board can be use for any serious
development.
This is a problem with MIPS-RIOT integration in general and was explained in the
PR removing mips-malta:
> a. Makes development & debugging way harder.
> b. It is impossible to run interactive tests.
> b.1. Constrains the rest of the platforms by providing an incentive to not
> make tests interactive.
> c. The lack of UART is a witness to the poor quality of the port.
This alone should have been enough reson not to merge this boards in the first place.
pic32-wifire is the least worse. At least it can be flashed from Linux, though it
is not an easy task. From dist/tools/pic32prog/doc.md
>It will require flashing a specific firmware on the PICkit3.
> As this can only be done from a Windows computer, that not many Linux users
> have, the following steps explain how to setup a Windows VirtualBox virtual
> machine and flash the PICkit3 from it.
>
> Informations come from this comment
>
> RIOT-OS#6092 (comment)
pic32-clicker HAS NO FLASHER and requires one to use MPLAB.
2. No maintainer
================
There is no (active) RIOT maintainer with deep knowledge of the boards and
platform. A quick search through the issues and PRs shows this.
3. Maintainability
==================
As a consequence of (1) and (2) many tests are not run in these boards. At the
same time, RIOT maintainers - especially those working on the build system - still
have to modify and migrate mips-foo boards.
The rest of the arguments here are the same as presented with the mips-malta
removal.
|
I'm against removing these. |
Ok, fine, but would you mind giving a rationale? I'm not dogmatic- I spelled out my arguments and if you counter them then of course I can change my opinion. |
This one puzzles me a lot. You've been sitting across @cladmi that whole time. It should have been a rather quick merge, if there'd been some communication between you guys. |
PS, off topic: "the colored output of our build system" is part of what makes it run as slow as it does, and AFAICT it is you who often complains about build times in the CI. Those long build times are caused by a combination of inept programming and extensive use of hacks, which is what I'm trying to ameliorate. |
|
One more point. I am paid with public funds, as is the case for many members of the RIOT community. It is therefore a duty for us who are paid by the public to constantly ask ourselves: how does this benefit the public? and, am I using public resources effectively and responsibly? |
|
Since there is some still work done by @francois-berder on these boards, I don't think we'll remove them for the moment. |
Why
There has not been any any progress towards addressing the issues put forward in ec3252b (part of #11788).
We already did away with malta. Now, shall we remove clicker and wifire too?
Before answering consider the following points:
Are clicker and wifire (in their present state) adding any substantial value to RIOT? Do they solve anyone's problems, compared to those which they create? Since this is a community effort: do they address any common, shared needs of (a relevant part of) the community?
Anyone trying to affirmatively answer the above would have to explain why #9259 is still unmerged after almost a year and half, and why it is being proposed by a person with no interest in pic32 or mips and whose time could be spent in ways more useful to our community.
What
Please see the commit description for a more complete explanation, also see the discussion in #11788.