boards/iotlab: rely on OPENOCD_RESET_USE_CONNECT_ASSERT_SRST#12153
Merged
aabadie merged 1 commit intoRIOT-OS:masterfrom Sep 10, 2019
Merged
Conversation
Use the new OPENOCD_RESET_USE_CONNECT_ASSERT_SRST to configure 'reset_config connect_assert_srst' when flashing and resetting only. This removes the need for a special debug configuration and should allow connecting to a running target again.
Contributor
Author
aabadie
approved these changes
Sep 10, 2019
Contributor
aabadie
left a comment
There was a problem hiding this comment.
Tested on IoT-LAB M3 and works the same.
ACK and go!
Contributor
Author
|
Thank you for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Use the new OPENOCD_RESET_USE_CONNECT_ASSERT_SRST to configure
'reset_config connect_assert_srst' when flashing and resetting only.
This removes the need for a special debug configuration and should allow
connecting to a running target again.
Testing procedure
When flashing the reset configuration used is the same (see the last line displayed in the output):
Output in the PR, the configuration is changed to the same as in master
Output in master until the reset configuration
Debug works
Issues/PRs references
Alternative way of doing #8977 that restores debug on a running target now that we have #11976