cpu/fe310: interrupt handling cleanup#12276
Merged
benpicco merged 1 commit intoRIOT-OS:masterfrom Sep 28, 2019
Merged
Conversation
kenrabold
force-pushed
the
pr-fe310_intr_cleanup
branch
from
fa09553 to
e844af5
Compare
benpicco
reviewed
Sep 23, 2019
benpicco
reviewed
Sep 23, 2019
benpicco
reviewed
Sep 23, 2019
benpicco
reviewed
Sep 23, 2019
benpicco
added
CI: ready for build
benpicco
approved these changes
Sep 27, 2019
Contributor
benpicco
left a comment
benpicco
left a comment
There was a problem hiding this comment.
This all looks pretty reasonable as far as I can tell.
Please squash.
Member
|
@benpicco did you test? |
miri64
added
CI: needs squashing
Cleanup of FE310 interrupt handler code Optimization of intr context frame Reduce size of intr stack Added unhandled trap output Fix PR RIOT-OS#12237
kenrabold
force-pushed
the
pr-fe310_intr_cleanup
branch
from
4b17661 to
1d6e37a
Compare
Contributor
Author
|
I tested these changes on both HiFive1 and HiFive1B boards with all tests\thread_* and tests\bench_* apps |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup of FE310 interrupt handler code
Optimization of intr context frame
Reduce size of intr stack
Added unhandled trap output
Fix PR #12237
Contribution description
Took a deeper look into the FE310 interrupt and trap handling code and decided to clean it up.
Simplified the interrupt handling assembly routine and added more debug output about faulting instructions and addresses.
Also addressed the duplicate LD files as mentioned in PR #12237
Testing procedure
Tested with all tests\thread_* and tests\bench_* apps
Tested with both HiFive1 and HiFive1B boards
Issues/PRs references
Fixes: PR #12237
References: #12110, #12196, #12109