shell_commands: gnrc_netif: only include LoRA options when LoRA PHY is present#12295
Merged
jia200x merged 1 commit intoRIOT-OS:masterfrom Sep 24, 2019
Merged
shell_commands: gnrc_netif: only include LoRA options when LoRA PHY is present#12295jia200x merged 1 commit intoRIOT-OS:masterfrom
jia200x merged 1 commit intoRIOT-OS:masterfrom
Conversation
10 tasks
miri64
previously requested changes
Sep 24, 2019
Member
|
Re-queued build, as the PR is still under discussion. |
Member
|
LGTM now. Let's see, what the LoRA crowd says to this. |
Mh... thought re-requesting my review would work. Oh well, then I dismiss it formally
Member
|
(IMHO this PR can be squashed) |
…s present If no LoRA module is used, there is no use in compiling in all the config options for LoRA PHYs. This saves about 1k of .text
1ae5a2e to
c31e373
Compare
Member
|
LGTM. I will test it now on real hardware |
Member
|
Tested on hardware (samr21-xpro and b-l072z-lrwan1). LoRa options are shown only in the b-l072z-lrwan1 (equipped with a LoRa radio). So it works |
Member
|
...& GO |
Contributor
Author
|
Thank you both for the fast review & test! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
If no LoRA module is used, there is no use in compiling in all the config options for LoRA PHYs.
This saves about 1k of
.text.It also slims down the switch case in
_print_netopt.Right now, adding only one more entry there will cause an error on AVR:
This is because there are too many cases and local jumps on that platform can only be so far.
Testing procedure
Compile e.g.
examples/gnrc_networkingforsamr21-xproBefore:
After:
Examples using the sx127x module should continue to work.
Issues/PRs references
this adapts the idea from #12171 to existing code.
In that PR, drivers will select a pseudomodule to indicate which PHY options they support