Skip to content

cpu/cortexm: don't disable IRQs in cpu_jump_to_image()#12312

Merged
maribu merged 1 commit intoRIOT-OS:masterfrom
kaspar030:cortexm_dont_disable_irq_in_cpu_jump_to_image
Oct 8, 2019
Merged

cpu/cortexm: don't disable IRQs in cpu_jump_to_image()#12312
maribu merged 1 commit intoRIOT-OS:masterfrom
kaspar030:cortexm_dont_disable_irq_in_cpu_jump_to_image

Conversation

@kaspar030
Copy link
Contributor

@kaspar030 kaspar030 commented Sep 26, 2019 •
edited
Loading

Contribution description

cpu_jump_to_image() disables IRQs. As the function is supposed to be called from bootloaders, this shouldn't be necessary.

Testing procedure

Primarily all users of riotboot must still work.

Issues/PRs references

Fixes #12311. edit fixed reference

@kaspar030 kaspar030 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Platform: ARM Platform: This PR/issue effects ARM-based platforms CI: run tests If set, CI server will run tests on hardware for the labeled PR labels Sep 26, 2019
@kaspar030 kaspar030 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Sep 26, 2019
@basilfx
Copy link
Member

basilfx commented Sep 27, 2019

I can verify that this fixes the issue I have in #12311. Tested this on the SLTB001a, SLSTK3401a, SLSTK3402a and STK3600.

@maribu
Copy link
Member

maribu commented Oct 8, 2019

OK, @basilfx tested this

@maribu maribu added the Reviewed: 3-testing The PR was tested according to the maintainer guidelines label Oct 8, 2019
maribu
maribu approved these changes Oct 8, 2019
View reviewed changes
Copy link
Member

@maribu maribu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And a code-wise ACK from me

@maribu maribu added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 8, 2019
@maribu maribu merged commit d749e2d into RIOT-OS:master Oct 8, 2019
@kaspar030 kaspar030 deleted the cortexm_dont_disable_irq_in_cpu_jump_to_image branch October 22, 2019 19:43
@kb2ma kb2ma added this to the Release 2019.10 milestone Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maribu maribu maribu approved these changes

@haukepetersen haukepetersen Awaiting requested review from haukepetersen

Assignees

No one assigned

Labels

CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Milestone

Release 2019.10

Development

Successfully merging this pull request may close these issues.

riotboot: irq not enabled after jumping to slot

4 participants

@kaspar030 @basilfx @maribu @kb2ma