cpu/fe310: use common names for heap markers#12328
Closed
benpicco wants to merge 1 commit intoRIOT-OS:masterfrom
Closed
cpu/fe310: use common names for heap markers#12328benpicco wants to merge 1 commit intoRIOT-OS:masterfrom
benpicco wants to merge 1 commit intoRIOT-OS:masterfrom
Conversation
Other archs use _sheap and _eheap to mark the start and end of the heap. For compatibility with common code, name them the same on fe310.
benpicco
added
Type: cleanup
benpicco
added
the
Impact: minor
Contributor
|
Affects PR #10953. |
benpicco
removed
the
Impact: minor
aabadie
added
CI: ready for build
Contributor
Author
|
@kenrabold any objections to the name change? |
Contributor
|
No objections from me |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions. |
stale
bot
added
the
State: stale
Contributor
|
@benpicco This PR was just forgotten, we should reopen it. |
Contributor
Author
|
Well this was a precursor for #12032 which seems equally abandoned. |
This was referenced Jul 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Other archs use
_sheapand_eheapto mark the start and end of the heap.fe310 uses
_heap_startand_heap_end, so platform independent code that wants to make use of this will needlessly fail.For compatibility with common code, name them the same on fe310
Testing procedure
Only variable names changed, the same binary should still be generated.
Issues/PRs references
needed for #12032