Sodaq boards arduino

[keestux]

Contribution description

This PR adds the Arduino include files for 4 Sodaq boards (Autonomo, Explorer, One, Sara AFF).

As an extra this PR also adds the ADC configuration for Sodaq Autonomo. Furthermore it adjusts the ADC configurations for the other Sodaq boards so that each of them can properly reads it BATVOLT.

Testing procedure

Build and run tests/periph_gpio_arduino and tests/sys_arduino.

[aabadie]

The CI is reporting trailing whitespaces. Otherwise the changes look good (even if not verified with the datasheet but I tend to trust you @keestux :) ).
I won't be able to test this PR on my Sodaq boards before next week unfortunately. Maybe just provide some output ?

[keestux]

@aabadie the only thing I did was to use the toggle command in tests/periph_gpio_arduino to switch on/off the LEDs.
When #12180 comes through there will be more ways to test. Not that I want to wait for that.

For ADC I just used tests/periph_adc. I think that all Sodaq boards have BATVOLT at the last ADC channel. The value should be somewhat stable when a battery is attached.

[aabadie]

Code changes look good. I trust @keestux tests.

ACK

Murdock found problems and there are indeed issues.

[aabadie]

Murdock is reporting an issue with tests/driver_hd44780.

Looking a second time into this PR, it seems arduino_pinmap.h is missing for all boards.

[keestux]

I'll have a look. My first impression is that this is a weird test to be part of RIOT.

[keestux]

Also adding @smlng because he added this test.

This test (tests/driver_hd44780) is the only thing in RIOT that actually uses ARDUINO_PIN_*. Why did we let that in? The test can only be used on one specific board with a particular pinout. There is no universal agreement in the Arduino world about the function of the pins. Pin2 on one arduino board can be totally different from pin2 on another board.

From the README of the test

• Pin 4 (RS or "register select") is connected to pin 2 on the Arduino
• Pin 6 (EN or "enable") is connected to pin 3 on the Arduino.
• Pin 11 on the LCD is connected to pin 4 on the Arduino.
• Pin 12 on the LCD is connected to pin 5 on the Arduino.
• Pin 13 on the LCD is connected to pin 6 on the Arduino.
• Pin 14 on the LCD is connected to pin 7 on the Arduino.

It does not even say which Arduino, is it Arduino Zero?

Can't we pin the test to just that board?

[keestux]

@aabadie For now I have added my boards to the black list of that test. Murdock is happy.

[aabadie]

Blacklisting the boards in the test application is ok: the same strategy was done for stm32f4discovery.
Still trusting @keestux tests and cde changes are good.

ACK

[keestux]

Thanks